test-cluster-disconnect-handles hanging in background on freebsd #6988
Comments
|
@nodejs/testing |
Trott
added
test
|
If nothing is jumping out at anyone in the code, maybe try running this test 10K times on freebsd in the stress test job and see if it fails at some point (and see if that failure causes subsequent runs to fail too). And, of course, fix whatever is causing the first failure. I guess in the time it took me to type that out, I could have just kicked off the job. So here it is: https://ci.nodejs.org/job/node-stress-single-test/744/nodes=freebsd102-64/console |
|
The stress test came back green. Are there any processes left behind? |
|
Expanding scope a bit, judging from failures like https://ci.nodejs.org/job/node-test-commit-arm/3454/nodes=armv7-ubuntu1404/consoleFull it seems that some test somewhere is not cleaning up after itself reliably, even when it succeeds. I imagine it would manifest as a stray node process running and keeping the port open, resulting in the plethora of EADDRINUSE errors. I imagine this is a likely source of this issue. Not sure of an easy way to identify the problematic test, though. EDIT: Oh, actually, maybe this is the culprit test... |
test-cluster-disconnect-handles already includes logic that tries to cleanup any child processes when the test fails. This commit adds additional checks to verify that the child exited normally, and fails the test if that is not the case. Refs: nodejs#6988 PR-URL: nodejs#6993 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
test-cluster-disconnect-handles already includes logic that tries to cleanup any child processes when the test fails. This commit adds additional checks to verify that the child exited normally, and fails the test if that is not the case. Refs: nodejs#6988 PR-URL: nodejs#6993 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
|
I think it can be closed. |
|
OK. Closing. Please reopen if you think it needs to be investigated further. |
test-cluster-disconnect-handles already includes logic that tries to cleanup any child processes when the test fails. This commit adds additional checks to verify that the child exited normally, and fails the test if that is not the case. Refs: #6988 PR-URL: #6993 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
test-cluster-disconnect-handles already includes logic that tries to cleanup any child processes when the test fails. This commit adds additional checks to verify that the child exited normally, and fails the test if that is not the case. Refs: #6988 PR-URL: #6993 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
test-cluster-disconnect-handles already includes logic that tries to cleanup any child processes when the test fails. This commit adds additional checks to verify that the child exited normally, and fails the test if that is not the case. Refs: #6988 PR-URL: #6993 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
test-cluster-disconnect-handles already includes logic that tries to cleanup any child processes when the test fails. This commit adds additional checks to verify that the child exited normally, and fails the test if that is not the case. Refs: #6988 PR-URL: #6993 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
test-cluster-disconnect-handles already includes logic that tries to cleanup any child processes when the test fails. This commit adds additional checks to verify that the child exited normally, and fails the test if that is not the case. Refs: #6988 PR-URL: #6993 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
test-cluster-disconnect-handles already includes logic that tries to cleanup any child processes when the test fails. This commit adds additional checks to verify that the child exited normally, and fails the test if that is not the case. Refs: #6988 PR-URL: #6993 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
found 10 instances of this running on one of the freebsd CI machines, e.g:
The text was updated successfully, but these errors were encountered: