Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8_inspector: IgnoreExceptionsScope.h does not exist #7944

Closed
bnoordhuis opened this issue Aug 2, 2016 · 3 comments
Closed

v8_inspector: IgnoreExceptionsScope.h does not exist #7944

bnoordhuis opened this issue Aug 2, 2016 · 3 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@bnoordhuis
Copy link
Member

deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/v8_inspector.gyp has a dependency on IgnoreExceptionsScope.h but that file does not exist anywhere under deps/v8_inspector.

Not fatal, but it makes some build systems complain.

cc @eugeneo @ofrobots

@bnoordhuis bnoordhuis added the inspector Issues and PRs related to the V8 inspector protocol label Aug 2, 2016
@eugeneo
Copy link
Contributor

eugeneo commented Aug 8, 2016

This will be fixed in the next inspector rollout. This fix is included in
this commit -
pavelfeldman/v8_inspector@e30c18e#diff-b779e8fd10a9a2ea53cb91d5bcb86bb5

On Tue, Aug 2, 2016 at 12:48 AM Ben Noordhuis [email protected]
wrote:

deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/v8_inspector.gyp
has a dependency on IgnoreExceptionsScope.h but that file does not exist
anywhere under deps/v8_inspector.

Not fatal, but it makes some build systems complain.

cc @eugeneo https://github.com/eugeneo @ofrobots
https://github.com/ofrobots


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7944, or mute the thread
https://github.com/notifications/unsubscribe-auth/AARkra-Pe4hZP62fohEMfazx4uQP-iAEks5qbvYzgaJpZM4JaVO-
.

@eugeneo
Copy link
Contributor

eugeneo commented Sep 9, 2016

I no longer see that file mentioned from the gyp file.

@cjihrig
Copy link
Contributor

cjihrig commented Sep 9, 2016

Confirmed that file appears to be gone. Going to close this. Please reopen if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

3 participants