-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test fix - fix to /test/parallel/test-cluster #10047
Conversation
37:5 error please use assert.strictEqual() instead of assert.equal() 39:5 error please use assert.strictEqual() instead of assert.equal()
10.5 error Please use assert.strictEqual() instead of assert.equal()
@@ -34,8 +34,8 @@ cat.on('exit', common.mustCall(function(status) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two assert.ok()
calls in this file that would be better off as strictEqual()
calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @cjihrig's suggestion
ping @sriluvan |
Hi.sorry for late response. Attending this now. |
This one looks like it changes |
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: nodejs#10047 Reviewed-By: James M Snell <[email protected]>
Landed in 72c773c. |
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <[email protected]>
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <[email protected]>
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <[email protected]>
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <[email protected]>
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <[email protected]>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test
Description of change
10:5 error Please use assert.strictEqual() instead of assert.strictEqual()