Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fix - fix to /test/parallel/test-cluster #10047

Closed
wants to merge 2 commits into from

Conversation

navulirs
Copy link
Contributor

@navulirs navulirs commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

10:5 error Please use assert.strictEqual() instead of assert.strictEqual()

37:5 error please use assert.strictEqual() instead of assert.equal()
39:5 error please use assert.strictEqual() instead of assert.equal()
10.5 error Please use assert.strictEqual() instead of assert.equal()
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@@ -34,8 +34,8 @@ cat.on('exit', common.mustCall(function(status) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two assert.ok() calls in this file that would be better off as strictEqual() calls.

@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. cluster Issues and PRs related to the cluster subsystem. net Issues and PRs related to the net subsystem. labels Dec 3, 2016
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @cjihrig's suggestion

@Trott
Copy link
Member

Trott commented Dec 8, 2016

@italoacasas italoacasas added the wip Issues and PRs that are still a work in progress. label Dec 12, 2016
@italoacasas
Copy link
Contributor

ping @sriluvan

@navulirs
Copy link
Contributor Author

Hi.sorry for late response. Attending this now.

@Trott
Copy link
Member

Trott commented Dec 22, 2016

This one looks like it changes test-child-process-stdin in error, as the same contributor is making these changes to that file in #10022. The change in test-cluster-net-listen.js here looks good so I'm going to land just that and leave the other file and other changes to the other PR.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 22, 2016
10.5 error Please use assert.strictEqual() instead of assert.equal()

PR-URL: nodejs#10047
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 22, 2016

Landed in 72c773c.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 22, 2016
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal()

PR-URL: #10047
Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal()

PR-URL: #10047
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added dont-land-on-v4.x and removed wip Issues and PRs that are still a work in progress. labels Jan 23, 2017
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal()

PR-URL: #10047
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal()

PR-URL: #10047
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal()

PR-URL: #10047
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants