inspector: check if connected before waiting #10094
Conversation
nodejs-github-bot
added
c++
|
|
||
| let child = null; | ||
|
|
||
| function DidNotShutdown() { |
There was a problem hiding this comment.
Can you make this didNotShutdown() please.
| common.fail('Did not shut down'); | ||
| } | ||
|
|
||
| const timeout = setTimeout(DidNotShutdown, 60 * 1000); |
There was a problem hiding this comment.
This seems like a long timeout for a test.
There was a problem hiding this comment.
I doubt it will ever trigger during a normal run because the test runner is going to kill the test after 5 or 10 seconds. It's probably easiest to simply scrap this code.
| common.fail('Did not shut down'); | ||
| } | ||
|
|
||
| const timeout = setTimeout(DidNotShutdown, 60 * 1000); |
There was a problem hiding this comment.
I doubt it will ever trigger during a normal run because the test runner is going to kill the test after 5 or 10 seconds. It's probably easiest to simply scrap this code.
|
Thank you for the reviews, I've updated the test case. |
|
|
||
| process.on('exit', exitHandler); | ||
| process.on('SIGINT', exitHandler); | ||
| process.on('SIGTERM', exitHandler); |
There was a problem hiding this comment.
Installing listeners for SIGINT and SIGTERM will override the default behavior of terminating when the signal is received. Call process.exit() in the callback.
There was a problem hiding this comment.
Thanks. It is now using exit code 1 to indicate error. I also removed the 'exit' handler.
|
|
||
| const child = spawn(process.execPath, | ||
| [ '--inspect', 'no-such-script.js' ], | ||
| { 'stdio': 'inherit' }); |
There was a problem hiding this comment.
Can you make the arguments line up?
|
Seems like https://ci.nodejs.org/job/node-test-pull-request/5269/ is all green but results are not reported back to GitHub for some reason. |
|
Landed as 2f3865d |
Fixes: #10093 PR-URL: #10094 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Fixes: #10093 PR-URL: #10094 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Fixes: #10093 PR-URL: #10094 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Fixes: #10093 PR-URL: #10094 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector: a check was added
Description of change
This change adds a check to see if there's a frontend connection before waiting for a disconnect.
Fixes: #10093