Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix setTimeout, add const, remove unused var #10207

Closed
wants to merge 1 commit into from

Conversation

sidthekidder
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test/parallel/test-domain.js

Description of change

Added 1ms delay for setTimeout and setInterval, instead of default 0. Changed var->const in 4 places. Removed unused function parameter.

@nodejs-github-bot nodejs-github-bot added dont-land-on-v7.x test Issues and PRs related to the tests. labels Dec 9, 2016
@mscdex mscdex added the domain Issues and PRs related to the domain subsystem. label Dec 9, 2016
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is ✅ .

Not sure why the bot labeled it don't-land-on-v7--maybe it sees a modified test and thinks it might be a behavior change?

@Trott
Copy link
Member

Trott commented Dec 9, 2016

@sidthekidder
Copy link
Contributor Author

The CI check failed on node-test-binary-arm » 6,pi1-raspbian-wheezy. Is there any way to see the stack trace, which line of code failed? Or is it related to this issue #8759.

@Trott
Copy link
Member

Trott commented Dec 10, 2016

The Raspberry Pi that failed had its failure during build and not test. That particular job doesn't run this test anyway. And that particular Raspberry Pi was having build failures throughout the day. (One of the admins rebooted it after I brought it to their attention, but that was after this CI run.)

In short, the single CI failure is unrelated and can be ignored.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 14, 2016
apply setTimeout duration, add const, remove unused var

PR-URL: nodejs#10207
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 14, 2016

Landed in ca58e53.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 14, 2016
MylesBorins pushed a commit that referenced this pull request Dec 15, 2016
apply setTimeout duration, add const, remove unused var

PR-URL: #10207
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
apply setTimeout duration, add const, remove unused var

PR-URL: #10207
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
apply setTimeout duration, add const, remove unused var

PR-URL: #10207
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
apply setTimeout duration, add const, remove unused var

PR-URL: #10207
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
apply setTimeout duration, add const, remove unused var

PR-URL: #10207
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
This was referenced Jan 24, 2017
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
apply setTimeout duration, add const, remove unused var

PR-URL: #10207
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
apply setTimeout duration, add const, remove unused var

PR-URL: #10207
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants