test: add known_issues test for #6287 #10266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
addaleax
reviewed
Dec 14, 2016
| Object.getOwnPropertyDescriptor(this, "x"); | ||
| `, context); | ||
|
|
||
| assert.equal(res.value, undefined); |
There was a problem hiding this comment.
Could you use assert.strictEqual here?
Deleting property in the vm context has no effect as reported in nodejs#6287 The test is moved to the known_issues and will be fixed with the 5.5 V8 API changes.
AnnaMag
force-pushed
the
vm-tests_knowns_issues
branch
from
342ce62
to
6dc6f09
Compare
|
@addaleax, good point, done. I appended the modified file to the latest commit and doing so erased your comment. Is there a better way of adding modifications without creating new commits, but leaving the revision history intact? |
|
@AnnaMag I’m not sure there’s anything wrong here? Github still has my comment available here in the thread. |
|
reopened as #10272 (mistake) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tests
Description of change
A test addressing #6287:
Deleting property in the vm context has no effectis moved to the known_issues directory.
It will be fixed with the 5.5 V8 API changes