Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-timers-this #10315

Closed
wants to merge 1 commit into from
Closed

test: refactor test-timers-this #10315

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 17, 2016 •
edited
Loading

  • use common.mustCall() and eliminate exit handler
  • provide timer durtion of 1ms where previously omitted
  • var -> const
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@Trott
test: refactor test-timers-this
ae7cb7a 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const
@Trott Trott added test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Dec 17, 2016
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 17, 2016
Fishrock123
Fishrock123 approved these changes Dec 17, 2016
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-pull-request/5453/

@Trott
Copy link
Member Author

Trott commented Dec 20, 2016

The two test failures appear unrelated but are troublingly similar:

https://ci.nodejs.org/job/node-test-binary-arm/5361/RUN_SUBSET=4,label=pi1-raspbian-wheezy/console:

not ok 107 parallel/test-npm-install
  ---
  duration_ms: 180.179
  severity: fail
  stack: |-
    timeout

https://ci.nodejs.org/job/node-test-binary-arm/5361/RUN_SUBSET=4,label=pi2-raspbian-wheezy/console:

not ok 107 parallel/test-npm-install
  ---
  duration_ms: 120.241
  severity: fail
  stack: |-
    timeout

I'm going to run CI again out of an abundance of caution.

@Trott
Copy link
Member Author

Trott commented Dec 21, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5497/

@Trott
Copy link
Member Author

Trott commented Dec 21, 2016

And CI was restarted in the middle of that last run or something and data was lost all over the place.

Let's try again: CI: https://ci.nodejs.org/job/node-test-pull-request/5503/

@Trott
Copy link
Member Author

Trott commented Dec 21, 2016

Hooray, CI is green.

Trott added a commit to Trott/io.js that referenced this pull request Dec 21, 2016
@Trott
test: refactor test-timers-this
6cb33c0 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: nodejs#10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 21, 2016

Landed in 6cb33c0

@Trott Trott closed this Dec 21, 2016
targos pushed a commit that referenced this pull request Dec 28, 2016
@Trott @targos
test: refactor test-timers-this
0acc025 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@Trott @evanlucas
test: refactor test-timers-this
8d16ab1 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@Trott @evanlucas
test: refactor test-timers-this
76b0e5b 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@Trott @MylesBorins
test: refactor test-timers-this
1e4f711 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@Trott @MylesBorins
test: refactor test-timers-this
d5babe6 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@Trott @MylesBorins
test: refactor test-timers-this
b611aad 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@Trott @MylesBorins
test: refactor test-timers-this
95e6989 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@Trott @MylesBorins
test: refactor test-timers-this
03bf87c 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@Trott @MylesBorins
test: refactor test-timers-this
90a79b3 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: #10315
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Trott Trott deleted the timer-this branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @Fishrock123 @targos @MylesBorins @nodejs-github-bot