Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: fix TracingController cleanup #10623

Closed
wants to merge 1 commit into from

Commits on Jan 5, 2017

  1. tracing: fix TracingController cleanup

    This fixes an incorrect deletion of the `TracingController` instance,
    which in some environments could cause an error about an invalid
    pointer passed to `free()`. The `TracingController` instance is
    actually owned by a `unique_ptr` member of the platform, so calling
    `platform::SetTracingController(nullptr)` is the correct way to
    delete it. But before that, the `TraceBuffer` must be deleted in
    order for the tracing loop to exit; that is accomplished by calling
    `TracingController::Initialize(nullptr)`.
    jasongin committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    ae7fca2 View commit details
    Browse the repository at this point in the history