test: improve module version mismatch error check #10636
Conversation
| 'was compiled against a different Node.js version using\n' + | ||
| 'NODE_MODULE_VERSION 42. This version of Node.js requires\n' + | ||
| `NODE_MODULE_VERSION ${process.versions.modules}.`); | ||
| `^Error: The module '.+'\n` + |
There was a problem hiding this comment.
Most node Error: messages don't insert line breaks into the message output.
Consider removing the newlines, so that the message can wrap at the user's terminal boundary, or in the case of stderr being directed to a log aggregation service, the entire error will be one single line/log entry.
I would make each sentence a single line, or maybe the entire thing two lines, with the second line being "Please try...".
There was a problem hiding this comment.
This PR is just improving the regular expression that matches the existing error message (which includes explicit line breaks). It's not changing the error message itself.
Refs: nodejs#10606 PR-URL: nodejs#10636 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: nodejs#10606 PR-URL: nodejs#10636 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Since #10606 is a |
Refs: #10606
Don't run the CI yet. The test will fail until #10606 lands.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test