Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add dgram.Socket.prototype.bind's test #10894

Closed
wants to merge 1 commit into from
Closed

test: add dgram.Socket.prototype.bind's test #10894

wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jan 19, 2017

bind: https://github.com/nodejs/node/blob/master/lib/dgram.js#L140

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 19, 2017
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Jan 19, 2017
mscdex
mscdex reviewed Jan 19, 2017
View reviewed changes
test/parallel/test-dgram-bind.js
@@ -5,7 +5,11 @@ const dgram = require('dgram');

const socket = dgram.createSocket('udp4');

socket.on('listening', function() {
socket.on('listening', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps wrap the callback in common.mustCall()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added.

lpinca
lpinca approved these changes Jan 19, 2017
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @mscdex's comment addressed.

@hiroppy hiroppy force-pushed the feature/add-socket-bind-test branch from faa7fa1 to ac999d3 Compare January 19, 2017 07:37
claudiorodriguez
claudiorodriguez approved these changes Jan 19, 2017
View reviewed changes
Copy link
Contributor

@claudiorodriguez claudiorodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@italoacasas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/5953/console

@targos
Copy link
Member

targos commented Jan 22, 2017

Landed in ff75e21

@targos targos closed this Jan 22, 2017
targos pushed a commit that referenced this pull request Jan 22, 2017
@hiroppy @targos
test: add dgram.Socket.prototype.bind's test
ff75e21 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@hiroppy hiroppy deleted the feature/add-socket-bind-test branch January 23, 2017 05:05
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@hiroppy @targos
test: add dgram.Socket.prototype.bind's test
8e3c142 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@hiroppy @italoacasas
test: add dgram.Socket.prototype.bind's test
90a9917 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: nodejs#10894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@hiroppy @italoacasas
test: add dgram.Socket.prototype.bind's test
5e364ad 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: nodejs#10894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@hiroppy @jasnell
test: add dgram.Socket.prototype.bind's test
535a424 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@hiroppy @jasnell
test: add dgram.Socket.prototype.bind's test
9232aa3 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@hiroppy @MylesBorins
test: add dgram.Socket.prototype.bind's test
2a52a68 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@hiroppy @MylesBorins
test: add dgram.Socket.prototype.bind's test
4d1f7b1 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@italoacasas italoacasas italoacasas approved these changes

@claudiorodriguez claudiorodriguez claudiorodriguez approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hiroppy @italoacasas @targos @mscdex @jasnell @lpinca @cjihrig @claudiorodriguez @nodejs-github-bot