Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check error msg in test/parallel/test-fs-make-callback.js #10914

Closed
wants to merge 2 commits into from
Closed

test: check error msg in test/parallel/test-fs-make-callback.js #10914

wants to merge 2 commits into from

Conversation

legalcodes
Copy link
Contributor

Check error message in test/parallel/test-fs-make-callback.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 20, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Jan 20, 2017
@targos
Copy link
Member

targos commented Jan 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5963/

Trott
Trott approved these changes Jan 20, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca
lpinca reviewed Jan 21, 2017
View reviewed changes
test/parallel/test-fs-make-callback.js
@@ -2,6 +2,8 @@
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const cbTypeError = /^TypeError: "callback" argument must be a function$/;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please remove this extra new line?

@lpinca
Copy link
Member

lpinca commented Jan 23, 2017

New CI: https://ci.nodejs.org/job/node-test-pull-request/5994/

@targos
Copy link
Member

targos commented Jan 24, 2017

Landed in 5614dc3. Thank you!

@targos targos closed this Jan 24, 2017
targos pushed a commit that referenced this pull request Jan 24, 2017
@legalcodes @targos
test: check error message in test-fs-make-callback
5614dc3 
Add a RegExp to `throws` assertions.

PR-URL: #10914
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@legalcodes @italoacasas
test: check error message in test-fs-make-callback
18f64c0 
Add a RegExp to `throws` assertions.

PR-URL: nodejs#10914
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@legalcodes @italoacasas
test: check error message in test-fs-make-callback
a9a5fa0 
Add a RegExp to `throws` assertions.

PR-URL: nodejs#10914
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@legalcodes @italoacasas
test: check error message in test-fs-make-callback
be3e82d 
Add a RegExp to `throws` assertions.

PR-URL: nodejs#10914
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@legalcodes @italoacasas
test: check error message in test-fs-make-callback
a669a6a 
Add a RegExp to `throws` assertions.

PR-URL: nodejs#10914
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@italoacasas italoacasas italoacasas approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@legalcodes @targos @lpinca @MylesBorins @jasnell @Trott @cjihrig @italoacasas @mscdex @nodejs-github-bot