Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update V8 flag in test #10917

Closed
wants to merge 1 commit into from
Closed

Conversation

ofrobots
Copy link
Contributor

--expose-debug-as is going away in V8 5.8. Switch test-preload.js to a flag
that still exists.

R=@nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

--expose-debug-as is deprecated in V8, switch test-preload.js to a flag
that still exists.
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 20, 2017
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@mscdex mscdex added process Issues and PRs related to the process subsystem. and removed dont-land-on-v7.x labels Jan 20, 2017
@targos
Copy link
Member

targos commented Jan 22, 2017

targos pushed a commit to targos/node that referenced this pull request Jan 22, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag
that still exists.

PR-URL: nodejs#10917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos
Copy link
Member

targos commented Jan 22, 2017

Landed in 4f8582e

@targos targos closed this Jan 22, 2017
targos pushed a commit that referenced this pull request Jan 28, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag
that still exists.

PR-URL: #10917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag
that still exists.

PR-URL: nodejs#10917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag
that still exists.

PR-URL: nodejs#10917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 8, 2017

This will need a backport PR if it needs to land in v4. Landing in v6.

jasnell pushed a commit that referenced this pull request Mar 8, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag
that still exists.

PR-URL: #10917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
--expose-debug-as is deprecated in V8, switch test-preload.js to a flag
that still exists.

PR-URL: #10917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants