doc: fix confusion markdown in util.markdown #1097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,8 +53,7 @@ argument. Supported placeholders are: | |||
|
|
|||
| * `%s` - String. | |||
| * `%d` - Number (both integer and float). | |||
| * `%j` - JSON. Replaced with the string `'[Circular]'` if the argument | |||
| contains circular references. | |||
| * `%j` - JSON. Replaced with the string `'[Circular]'` if the argument contains circular references. | |||
There was a problem hiding this comment.
This line is over 80 characters now. Could you just remove the indentation from the original text?
|
Fixed @cjihrig Thank you |
|
looks good to me |
brendanashworth
pushed a commit
that referenced
this pull request
Mar 8, 2015
PR-URL: #1097 Reviewed-By: Brendan Ashworth <[email protected]>
|
Thanks for your link, @brendanashworth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught this one in reading the
utildoc, checked the doc of nodej and iojs:But the github markdown worked at https://github.com/iojs/io.js/blob/v1.x/doc/api/util.markdown#utilformatformat-
Well, now I fixed the confusion bug on on this line, but btw, I think we should keep using the markdown parser same to github markdown, so that we needn't another review on website. I'm interested in this proposal if someone could give me the guiding link on how the website are built and working, Thank you :)