url: make URLSearchParams properties spec-compliant #11057
Conversation
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
|
@joyeecheung, just requested a review from you as you are the author of #10408 |
| @@ -647,6 +647,35 @@ function getObjectFromParams(array) { | |||
| return obj; | |||
| } | |||
|
|
|||
| // Mainly to mitigate func-name-matching ESLint rule | |||
| function defineIDLClass(proto, classStr, obj) { | |||
There was a problem hiding this comment.
I'm wondering if there is a possibility/necessity to generate these stuff from an IDL file, like what browsers do, if there will be more convergence with Web APIs in Node core (console, crypto, streams, etc.) Not that this is what this PR should deal with though(and this is just to mitigate func-name-matching anyway, not full-on generation), just a thought.
Also the name is a little bit too general, could be something like defineIDLData or defineIDLValues, since it's about properties that need to be defined with value.
There was a problem hiding this comment.
That would likely be a bit overkill at the moment. This is the only IDL defined API we have currently. Eventually if we go down that road more then we can consider this.
| value: obj[key] | ||
| }); | ||
| } | ||
| for (const key of Object.getOwnPropertySymbols(obj)) { |
There was a problem hiding this comment.
Would be easier to read if s/key/symbol/, or just separate the two mixins(take operations and symbols as arguments instead of one obj)
PR-URL: #11057 Fixes: #10799 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
|
Landed in 90c2ac7 |
PR-URL: #11057 Fixes: #10799 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Define
URLSearchParamsmethods as enumerable, writable, configurable, as have already been done toURLin #10408. Also adjust the@@toStringTagvariable, as done toURLin #10906.Fixes: #10799
Benchmark (no significant differences)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url