doc: document clientRequest.aborted #11544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for http clientRequest.aborted.
nodejs-github-bot
added
doc
sam-github
approved these changes
Feb 24, 2017
jasnell
approved these changes
Feb 25, 2017
lpinca
approved these changes
Feb 25, 2017
cjihrig
approved these changes
Feb 25, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 27, 2017
Add documentation for http clientRequest.aborted. PR-URL: #11544 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 30d85d7 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 28, 2017
Add documentation for http clientRequest.aborted. PR-URL: nodejs#11544 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Add documentation for http clientRequest.aborted. PR-URL: #11544 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Add documentation for http clientRequest.aborted. PR-URL: #11544 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Add documentation for http clientRequest.aborted. PR-URL: #11544 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Add documentation for http clientRequest.aborted. PR-URL: #11544 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for http clientRequest.aborted.
This property was added in nodejs/node-v0.x-archive#7533. It's not prefixed so it doesn't seem to be private. It appears necessary to use it to check if a request was explicitly aborted (i.e. with
req.abort()) inside of areq.on("error", ...)listener.(I was surprised that the "error" event fires after explicitly calling
req.abort(), but doubt that behavior can change. As @cjihrig pointed out here, aborting a connection is not an error.)Checklist
Affected core subsystem(s)
doc, http