src: add HAVE_OPENSSL directive to openssl_config

[danbev]

Currently when building with the following configuration options:
$ ./configure --without-ssl && make

The following link error is reported:

Undefined symbols for architecture x86_64:
"node::openssl_config", referenced from:
node::Init(int*, char const**, int*, char const***) in node.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see
invocation)

Adding an HAVE_OPENSSL directive around this code allows the build to
pass.

PR-URL: #11618
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Ben Noordhuis [email protected]
Reviewed-By: Sam Roberts [email protected]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

src

[sam-github]

@gibfahn @gdams @nodejs/build what would it take to get a build job added, linux only would be ok, to build and test without openssl? There is a steady stream of fixes coming in for code and tests that don't work properly when node isn't built with openssl support, it would be good to catch these problems during PR not after the fact.

[gibfahn]

@sam-github if we were only building/testing on one platform it shouldn't be too hard, and if we run it on one of our quicker platforms it shouldn't slow down the CI run (our quickest job builds and tests in under 3 minutes).

I'll raise an issue on the build repo to track adding the job.

EDIT: nodejs/build#643

[danbev]

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/8372/

[Trott]

I'm going to close this because it targets v7.x and there's no more releases planned for that release line. If I'm mistaken here about something somehow, of course, just re-open and apologies in advance.