Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove incorrect arg in vcbuild.bat #1198

Merged
merged 1 commit into from
Mar 19, 2015

Conversation

Fishrock123
Copy link
Contributor

Looks like this was wrongly committed in f19e9b6

R=@rvagg

@Fishrock123
Copy link
Contributor Author

@rvagg
Copy link
Member

rvagg commented Mar 19, 2015

ouch! I was messing with that locally but it looks like it slipped in

@rvagg
Copy link
Member

rvagg commented Mar 19, 2015

lgtm btw, :shipit: now

@Fishrock123
Copy link
Contributor Author

I'll land after the CI runs on windows.

@Fishrock123
Copy link
Contributor Author

@rvagg No timeouts on both windows machines! @mathiask88 thanks again for finding this!

This change had been incorrectly committed in f19e9b6

Reviewed-By: Rod Vagg <[email protected]>
@Fishrock123 Fishrock123 merged commit 7d65d9a into nodejs:v1.x Mar 19, 2015
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Mar 19, 2015
This change had been incorrectly committed in f19e9b6

PR-URL: nodejs#1198
Reviewed-By: Rod Vagg <[email protected]>
@rvagg rvagg mentioned this pull request Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants