Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,benchmark: enable minimal CI for http bench #12025

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 24, 2017

Enable minimal CI testing for http benchmarks. This required making the
duration of some benchmarks configurable. They had been defaulting to 10
seconds each.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark

Enable minimal CI testing for http benchmarks. This required making the
duration of some benchmarks configurable. They had been defaulting to 10
seconds each.
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. labels Mar 24, 2017
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. labels Mar 24, 2017
@Trott
Copy link
Member Author

Trott commented Mar 24, 2017

Time to find out if this works cross-platform....

CI: https://ci.nodejs.org/job/node-test-pull-request/7025/

@Trott
Copy link
Member Author

Trott commented Mar 24, 2017

Looks like this will need one of:

  • autocannon or wrk installed on all the CI machines
  • configure the test to skip test files that use the external http benchmarkers (easy, but also kind of defeats the purpose of the test)
  • implement a feature that allows some kind of dummy/minimal benchmarker to be used; it doesn't have to give reliable results; it just has to check the config options it receives, make sure the URL supplied is reachable, and return quickly to keep the test nice and short

The last option is probably the best? ¯\(ツ)

Marking as stalled for now.

/cc @nodejs/build and @nodejs/testing in case there are any strong opinions

@Trott Trott added the stalled Issues and PRs that are stalled. label Mar 24, 2017
@Trott
Copy link
Member Author

Trott commented Apr 9, 2017

Superseded by #12121

@Trott Trott closed this Apr 9, 2017
@Trott Trott deleted the test-benchmark-http branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. stalled Issues and PRs that are stalled. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants