util: use [Array] for deeply nested arrays
#12046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
semver-major
|
@vsemozhetbyt Yes, thank you. :) |
Prefer `[Array]` over `[Object]` because the latter is confusing. Ref: nodejs#11651 PR-URL: nodejs#12046
addaleax
force-pushed
the
util-deep-array
branch
from
2cdb13d
to
1ddf199
Compare
evanlucas
approved these changes
Mar 26, 2017
targos
approved these changes
Mar 26, 2017
cjihrig
approved these changes
Mar 26, 2017
jasnell
approved these changes
Mar 26, 2017
addaleax
commented
Mar 26, 2017
| @@ -72,6 +72,8 @@ assert.strictEqual(util.inspect({'a': {'b': { 'c': 2}}}, false, 0), | |||
| '{ a: [Object] }'); | |||
| assert.strictEqual(util.inspect({'a': {'b': { 'c': 2}}}, false, 1), | |||
| '{ a: { b: [Object] } }'); | |||
There was a problem hiding this comment.
@cjihrig This should keep covering the else branch
|
CI: https://ci.nodejs.org/job/node-test-commit/8722/ (oops, didn’t see Jeremiah’s CI run … ¯\_(ツ)_/¯) |
|
CI failures are unrelated. |
jasnell
pushed a commit
that referenced
this pull request
Mar 28, 2017
Prefer `[Array]` over `[Object]` because the latter is confusing. PR-URL: #12046 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Landed in 4a5a944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer
[Array]over[Object]because the latter is confusing.I may be mistaken but I think this was brought up somewhere a few weeks ago (?) – I couldn’t find anything, but if somebody has aFixes:tag I’ll happily ad it, and if this is a duplicate, I’ll happily close the PR. :)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util