-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-cli-syntax assertions on windows #12212
test: fix test-cli-syntax assertions on windows #12212
Conversation
We should land this ASAP (once CI passes) to fix CI on windows master. cc/ @nodejs/platform-windows |
I hate the |
LGTM if the CI is green |
This LGTM as-is, although I think I'd prefer |
@Trott I agree that would have been better, but for now I think I'm going to land this as-is so that the build on master can be fixed ASAP. I can follow up with another PR to improve the error message. |
The test introduced in a5f91ab accidentally introduced failures on some windows builds. Update the assertion that was causing the failures. PR-URL: nodejs#12212 Ref: nodejs#11689 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
96e8c61
to
9348f31
Compare
Landed in 9348f31 |
This fixes a bug that was introduced in a semver-major commit -- it doesn't seem like it makes sense to backport. |
The test introduced in a5f91ab accidentally introduced failures on some windows builds. Update the assertion that was causing the failures.
Ref: #11689
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test