doc: add sub domain to host in url #12233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
styfle
changed the title
TimothyGu
suggested changes
Apr 5, 2017
There was a problem hiding this comment.
There are a couple more places you need to change:
- https://github.com/styfle/node/blame/441350fe938a1c90da11834c918f01196acd36b9/doc/api/url.md#L19
- https://github.com/styfle/node/blame/441350fe938a1c90da11834c918f01196acd36b9/doc/api/url.md#L331
- https://github.com/styfle/node/blame/441350fe938a1c90da11834c918f01196acd36b9/doc/api/url.md#L347
|
@TimothyGu Thanks, I can't believe I missed that! I went ahead and changed all |
TimothyGu
approved these changes
Apr 5, 2017
vsemozhetbyt
added
the
whatwg-url
vsemozhetbyt
approved these changes
Apr 5, 2017
TimothyGu
changed the title
jasnell
approved these changes
Apr 6, 2017
lpinca
approved these changes
Apr 7, 2017
cjihrig
approved these changes
Apr 7, 2017
|
Landed in 9acd6c9. |
TimothyGu
pushed a commit
that referenced
this pull request
Apr 7, 2017
PR-URL: #12233 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
PR-URL: nodejs#12233 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to better illustrate what happens to the sub domain when parsing a URL.
Checklist
Affected core subsystem(s)