Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add basic cctest for base64.h #12238

Closed
wants to merge 2 commits into from
Closed

Commits on Apr 5, 2017

  1. test: add basic cctest for base64.h

    This commit adds C++ tests for `base64_encode()` and `base64_decode()`
    functions defined in `base64.h`.  The functionality is already being
    tested indirectly in JavaScript tests for Buffer, but it won't hurt to
    test the low-level functions too, especially given that they aren't only
    used in the internal Buffer implementation, Chrome inspector protocol
    support relies upon them too.
    
    Refs: nodejs#12146 (comment)
    aqrln committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    3c48697 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2017

  1. fixup! use const pointers

    Add accidentally omitted consts for pointers to allocated buffers.
    This doesn't actually affect anything in this code, but make const,
    not var ;)
    aqrln committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    851e835 View commit details
    Browse the repository at this point in the history