lib: remove : from protocol in Url.parse().

[anio]

I only removed : from parsed protocol.

[Fishrock123]

What is the purpose of this?

[mscdex]

If there is always a : at the end, you could avoid the regexp with lowerProto.slice(0, -1)

[bnoordhuis]

I move we just close this. It breaks all code ever written against the url module, including the test suite, for no good reason.

[kenany]

Previously: nodejs/node-v0.x-archive#1580

Current behavior matches the browser:

(new URL('https://github.com/iojs/io.js/pull/1237')).protocol
// => 'https:'

[Fishrock123]

Might as well keep it like the browser.

[anio]

KenanY, bnoordhuis
OK, but is it correct? I refer you to RFC 3986

[Fishrock123]

@aino please read nodejs/node-v0.x-archive#1580

[kenany]

@anio That describes the syntax of URLs and how they are constructed, not how to parse them. If anything, you'd have to "fix" this in the browsers first before here. Although, it's worth pointing out that the colon is part of the spec.

[anio]

:) Thanks guys.