-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: changed equality comparison to identity operator #12405
Conversation
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green
Minor nit for whoever lands this (or if @fcampinho wants to fix it up and force push, that's cool too): First word of the commit message should be an imperative verb, so |
Minor nit part 2: The first line should be 50 chars max so maybe |
Changed the equality comparison from == to identity operator ===
db758c7
to
949fa58
Compare
Sorry @Trott , first commit, I executed a git push --force |
Changed the equality comparison from == to identity operator === PR-URL: nodejs#12405 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
Landed in 7044065 |
Thanks for the contribution! 🎉 |
Should land after #11705 |
Changed the equality comparison from == to identity operator === PR-URL: #12405 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
Changed the equality comparison from == to identity operator === PR-URL: #12405 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
test: changed equality comparison to identity operator
Changed the equality comparison from == to identity operator ===
make -j4 test
(UNIX), orvcbuild test
(Windows) passes