minor fix: removed < in changelog.md #12434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
|
Change looks good but could you format your commit message according to the Contributing Guidelines? Maybe something like this? If you don't have time it can be rewritten by whoever lands this, but if you are going to help out more on the project (as I hope you do), then it saves work if you produce better commit messages. |
gibfahn
approved these changes
Apr 15, 2017
TimothyGu
reviewed
Apr 15, 2017
CHANGELOG.md
Outdated
| @@ -29,7 +29,7 @@ release. | |||
| <tr> | |||
| <td valign="top"> | |||
| <b><a href="doc/changelogs/CHANGELOG_V7.md#7.9.0">7.9.0</a></b><br/> | |||
| <a href="doc/changelogs/CHANGELOG_V7.md#7.8.0<">7.8.0<</a><br/> | |||
| <a href="doc/changelogs/CHANGELOG_V7.md#7.8.0<">7.8.0</a><br/> | |||
There was a problem hiding this comment.
Would you mind fixing the extra < after the CHANGELOG_V7.md#7.8.0 as well?
TimothyGu
approved these changes
Apr 15, 2017
|
LGTM |
jseijas
approved these changes
Apr 16, 2017
cjihrig
approved these changes
Apr 16, 2017
|
@gibfahn Reworded and squashed 🔪 |
|
Landed in b837bd2. @gautamkrishnar next time, make sure to include Fixes: https://github.com/nodejs/node/issues/12430in your commit message as well. |
TimothyGu
pushed a commit
that referenced
this pull request
Apr 16, 2017
PR-URL: #12434 Fixes: #12430 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
|
@TimothyGu thanks for correcting me. I will surely do that next time... |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a typo....
Fixes:#12430