Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove common.PORT from cluster-worker-disconnect-on-error #12457

Closed
wants to merge 1 commit into from
Closed

tests: remove common.PORT from cluster-worker-disconnect-on-error #12457

wants to merge 1 commit into from

Conversation

sebastianplesciuc
Copy link

Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

Refs: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 17, 2017
@sebastianplesciuc
Copy link
Author

Felt like this change warranted another pull request since it's not just an argument change. Please let me know if it can be improved.

@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Apr 17, 2017
benjamingr
benjamingr approved these changes Apr 17, 2017
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, although I'd change:

+    if (typeof msg.port != 'undefined') {

To assert that message.port is not undefined rather than ignore the message in that case and add a mustCall assertion.

santigimeno
santigimeno requested changes Apr 17, 2017
View reviewed changes
test/parallel/test-cluster-worker-disconnect-on-error.js Outdated
const worker = cluster.fork();
worker.send({port: server.address().port});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would send the port info in the listen() callback

test/parallel/test-cluster-worker-disconnect-on-error.js Outdated
server.on('error', common.mustCall((e) => {
cluster.worker.disconnect();
}));
process.on('message', function(msg) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wrap the callback with common.mustCall()

test: dynamic port in cluster worker disconnect
1c937a5 
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

Refs: #12376
@sebastianplesciuc
Copy link
Author

@benjamingr @santigimeno I made the requested changes. I hope I understood your suggestions. Please let me know how it looks. Thanks!

@sebastianplesciuc sebastianplesciuc changed the title Migrate cluster worker disconnect on error test from common.PORT tests: remove common.PORT from cluster-worker-disconnect-on-error Apr 17, 2017
@Trott Trott mentioned this pull request Apr 17, 2017
Closed
64 tasks
jasnell pushed a commit that referenced this pull request Apr 19, 2017
@jasnell
test: dynamic port in cluster worker disconnect
a2843f2 
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12457
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 19, 2017

Landed in a2843f2

@jasnell jasnell closed this Apr 19, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@evanlucas
test: dynamic port in cluster worker disconnect
7f7f872 
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12457
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@evanlucas
test: dynamic port in cluster worker disconnect
d93f204 
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12457
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@evanlucas
test: dynamic port in cluster worker disconnect
a213320 
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12457
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@gibfahn
test: dynamic port in cluster worker disconnect
3e190b2 
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12457
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@MylesBorins
test: dynamic port in cluster worker disconnect
768431c 
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12457
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@andrew749
test: dynamic port in cluster worker disconnect
2c1524e 
Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: nodejs/node#12457
Ref: nodejs/node#12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sebastianplesciuc @jasnell @santigimeno @benjamingr @cjihrig @hiroppy @mscdex @gibfahn @nodejs-github-bot