-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: document repl on-demand loading #1249
Conversation
@@ -166,6 +166,9 @@ Example of listening for `reset`: | |||
Inside the REPL, Control+D will exit. Multi-line expressions can be input. | |||
Tab completion is supported for both global and local variables. | |||
|
|||
Core modules will be on-demand loaded into the environment. For example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just swap loaded and on-demand :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "loaded on-demand" would sound better here. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, didn't even realize @Fishrock123 beat me to it :)
LGTM with nit |
8e3c30e
to
ff266fc
Compare
ff266fc
to
9834eef
Compare
LGTM too. |
Fixes: #992 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]> PR-URL: #1249
merged in e84dd5f |
Continuation of #1248. Related: #992.
@Fishrock123 : Updated, please check again