test: remove AIX guard in fs-options-immutable #12687
Conversation
thefourtheye
added
aix
| if (!common.isAix) { | ||
| // TODO(thefourtheye) Remove this guard once | ||
| // https://github.com/nodejs/node/issues/5085 is fixed | ||
| { |
There was a problem hiding this comment.
Can we just get rid of this start brace and its matching end brace and re-indent the enclosed code?
There was a problem hiding this comment.
All the other tests also have this block thing. I thought it would be consistent. If you want to remove it, I can do it.
There was a problem hiding this comment.
Well IMHO it's excessive since it doesn't (directly) provide scoping for any variables (or any code for that matter). I don't know how everyone else feels about it.
There was a problem hiding this comment.
Wouldn't removing the outer block still be consistent with the rest of the test because everything inside that block scope is itself block-scoped? So you'd end up with this block-scoped code?:
{
let watch;
assert.doesNotThrow(() => {
watch = fs.watch(__filename, options, common.noop);
});
watch.close();
}
{
assert.doesNotThrow(() => fs.watchFile(__filename, options, common.noop));
fs.unwatchFile(__filename);
}There was a problem hiding this comment.
Oh yeah, makes sense. Removed that block now...
The fs watch test was not run on AIX till now because of the known issue, nodejs#5085. Now that it is completed, this guard can be removed.
thefourtheye
force-pushed
the
make-fs-options-immutable-available-on-aix
branch
from
c54f8a5
to
aafd390
Compare
|
CI Run: https://ci.nodejs.org/job/node-test-pull-request/7700/ (after removing the block) |
|
LGTM |
|
LGTM but I'd appreciate a review from @gireeshpunathil |
|
Landed in b16869c , thanks @thefourtheye ! |
The fs watch test was not run on AIX till now because of the known issue, #5085. Now that it is completed, this guard can be removed. PR-URL: #12687 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
|
Depends on #7831 which is |
The fs watch test was not run on AIX till now because of the known
issue, #5085. Now that it is
completed, this guard can be removed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs aix test
@nodejs/platform-aix