-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: make SIGPROF message a real warning #12709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have a test if that’s possible (it might be?) but LGTM either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @addaleax that a test would be good if possible but otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test and CI, but otherwise LGTM
So it looks like the inspector is always started by default, making the surrounding |
@cjihrig That sounds incorrect to me too. That is why I was wondering in the issue why the event emitted even though we were not using the inspector... |
We always attempt to start the inspector, but it doesn't necessarily succeed. I follow Line 3986 in 6bcf65d
Also, building without the inspector cause it not to start :-) Since SIGPROF is for the profiling timer (see |
Right, we always attempt to start the inspector unless Node is built without it. If others are ok with this behavior, I can add a simple regression test. |
Test added. CI: https://ci.nodejs.org/job/node-test-pull-request/7993/ |
This commit replaces a fprintf() with a call to ProcessEmitWarning(). Refs: nodejs#12706 PR-URL: nodejs#12709 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This commit replaces a fprintf() with a call to ProcessEmitWarning(). Refs: nodejs#12706 PR-URL: nodejs#12709 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This commit replaces a
fprintf()
with a call toProcessEmitWarning()
.R= @Fishrock123
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
src