Revert "src: fix delete operator on vm context" #12721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 587857e. It was found to have subtle behavior changes
nodejs-github-bot
added
c++
|
LGTM but can you describe or link to a description of what those behavior changes are? :-) |
|
We introduced the following change in 7: When we delete an object on the sandbox, we also delete it on the current global proxy. This got accidently ported to 6.x and is reverted here. LGTM. |
fhinkel
approved these changes
Apr 28, 2017
MylesBorins
added a commit
that referenced
this pull request
Apr 29, 2017
This reverts commit 587857e. It was found to have subtle behavior changes in deleting objects. PR-URL: #12721 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
|
Landed in f919807 |
MylesBorins
added a commit
that referenced
this pull request
Apr 29, 2017
This reverts commit 587857e. It was found to have subtle behavior changes in deleting objects. PR-URL: #12721 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
This reverts commit 587857e. It was found to have subtle behavior changes in deleting objects. PR-URL: nodejs/node#12721 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 587857e. It was found to have subtle
behavior changes
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)