(v6.x backport) doc types fixes #13054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
This was referenced May 16, 2017
|
Once this has landed #9532 should be attempted to be backported. |
|
This doesn't apply cleanly, I think because it was raised against @silverwind I've updated the base branch in this PR, could you rebase against |
|
Meh, I was specifically asked to target |
silverwind
force-pushed
the
doc-types-backport
branch
from
d266701
to
356d59f
Compare
|
How's it now? |
silverwind
force-pushed
the
doc-types-backport
branch
3 times, most recently
from
1c6abfb
to
a207db0
Compare
|
(Fixed a few oversights) |
gibfahn
approved these changes
May 16, 2017
silverwind
force-pushed
the
doc-types-backport
branch
from
a207db0
to
9b0fb17
Compare
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
May 16, 2017
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: #11697 Backport-PR-URL: #13054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
|
FWIW the backporting guide should be clear about which branch to backport to, LMK if anything in that is unclear. |
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: #11697 Backport-PR-URL: #13054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
PR-URL: nodejs#11658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: nodejs#11697 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
silverwind
force-pushed
the
doc-types-backport
branch
from
11918c4
to
6014aa7
Compare
|
Done. I noticed docs for |
gibfahn
pushed a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
PR-URL: nodejs#11167 Backport-PR-URL: nodejs#13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
gibfahn
pushed a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
PR-URL: nodejs#11167 Backport-PR-URL: nodejs#13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
gibfahn
pushed a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
PR-URL: nodejs#11658 Backport-PR-URL: nodejs#13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn
pushed a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: nodejs#11697 Backport-PR-URL: nodejs#13054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: #11697 Backport-PR-URL: #13054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: #11697 Backport-PR-URL: #13054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
|
@silverwind, @gibfahn There are some |
|
Must've missed those. They are in |
|
@silverwind It seems only in |
silverwind
added a commit
to silverwind/node
that referenced
this pull request
Jul 18, 2017
The backport in nodejs#13054 contained a leftover section from the WHATWG url.format, in addition to the existing url.format. This removes this section.
|
Filed #14351 |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 18, 2017
The backport in #13054 contained a leftover section from the WHATWG url.format, in addition to the existing url.format. This removes this section.
MylesBorins
pushed a commit
that referenced
this pull request
Jul 18, 2017
The backport in #13054 contained a leftover section from the WHATWG url.format, in addition to the existing url.format. This removes this section. PR-URL: #14351 Reviewed-By: Myles Borins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport for these commits:
ff13619
9be03a2
172be50
5f32024
cc: @MylesBorins