doc: remove Gitter badge from README #13231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
changed the title
Trott
force-pushed
the
we-dont-need-no-stinking-badges
branch
from
3f48bf6
to
8729811
Compare
bnoordhuis
approved these changes
May 26, 2017
refack
approved these changes
May 26, 2017
cjihrig
approved these changes
May 26, 2017
gibfahn
approved these changes
May 26, 2017
watilde
approved these changes
May 26, 2017
silverwind
approved these changes
May 26, 2017
thefourtheye
approved these changes
May 28, 2017
|
I'm +1 on removing the gitter badge. My preference on the CII badge would be to simply move it further down the page... perhaps at the bottom just as additional information. |
Trott
force-pushed
the
we-dont-need-no-stinking-badges
branch
4 times, most recently
from
490e507
to
c771b9a
Compare
|
Since there is some hesitation at removing the Core Infrastructure Initiative badge, I've dialed this back to just removing the Gitter badge, for which there is consensus. (If anyone wants to either relocate or remove the CII badge too, please open another PR!) |
Trott
changed the title
Trott
force-pushed
the
we-dont-need-no-stinking-badges
branch
from
c771b9a
to
dad32c1
Compare
Trott
changed the title
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter.
Trott
force-pushed
the
we-dont-need-no-stinking-badges
branch
from
dad32c1
to
cb11574
Compare
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 29, 2017
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter. PR-URL: nodejs#13231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
Landed in 19fdb54 |
|
jasnell
pushed a commit
that referenced
this pull request
May 29, 2017
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter. PR-URL: #13231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter. PR-URL: #13231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter.
Checklist
Affected core subsystem(s)
doc