Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix order of ESLint rules #13363

Closed
wants to merge 1 commit into from
Closed

tools: fix order of ESLint rules #13363

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 1, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 1, 2017
charmander
charmander reviewed Jun 1, 2017
View reviewed changes
.eslintrc.yaml Outdated
message: Use assert.notStrictEqual() rather than assert.notEqual().
- property: __defineGetter__
message: __defineGetter__ is deprecated.
- property: __defineSetter__,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the comma here also be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done.

mhdawson
mhdawson approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott
Trott approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if linter is green

@watilde
Copy link
Member

watilde commented Jun 2, 2017

lint ci: https://ci.nodejs.org/job/node-test-linter/9544/

targos added a commit to targos/node that referenced this pull request Jun 6, 2017
@targos
tools: fix order of ESLint rules
f1199c2 
PR-URL: nodejs#13363
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@targos
Copy link
Member Author

targos commented Jun 6, 2017

Landed in f1199c2

@targos targos closed this Jun 6, 2017
@targos targos deleted the eslint-rule-order branch June 6, 2017 08:20
jasnell pushed a commit that referenced this pull request Jun 7, 2017
@targos @jasnell
tools: fix order of ESLint rules
01278bd 
PR-URL: #13363
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmander charmander charmander left review comments

@gibfahn gibfahn gibfahn approved these changes

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.