Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: make sure .{en|dis}able() === this #13418

Closed
wants to merge 1 commit into from
Closed

async_hooks: make sure .{en|dis}able() === this #13418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class AsyncHook {

// Each hook is only allowed to be added once.
if (hooks_array.includes(this))
return;
return this;

if (!setupHooksCalled) {
setupHooksCalled = true;
Expand Down Expand Up @@ -124,7 +124,7 @@ class AsyncHook {

const index = hooks_array.indexOf(this);
if (index === -1)
return;
return this;

hook_fields[kInit] -= +!!this[init_symbol];
hook_fields[kBefore] -= +!!this[before_symbol];
Expand Down
20 changes: 20 additions & 0 deletions test/parallel/test-async-hooks-enable-disable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const async_hooks = require('async_hooks');

const hook = async_hooks.createHook({
init: common.mustCall(() => {}, 1),
before: common.mustNotCall(),
after: common.mustNotCall(),
destroy: common.mustNotCall()
});

assert.strictEqual(hook.enable(), hook);
assert.strictEqual(hook.enable(), hook);

setImmediate(common.mustCall());

assert.strictEqual(hook.disable(), hook);
assert.strictEqual(hook.disable(), hook);
assert.strictEqual(hook.disable(), hook);