build,windows: check for VS version and arch #13485

refack · 2017-06-05T21:46:27Z

Fixes: #13398

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build,windows

refack · 2017-06-05T21:55:16Z

@seishun can you verify this fix, I don't have a machine with both VS2015 & VS2017 installed.

refack · 2017-06-05T21:56:39Z

Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/9597/

digitalinfinity · 2017-06-06T04:19:47Z

LGTM - cc @joaocgreis @kunalspathak

seishun · 2017-06-06T06:44:12Z

@refack This is the error I get with your PR after running vcbuild, then vcbuild vs2017:

C:\Users\Nikolai\Downloads\node\deps\cares\cares.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D
efault.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on
disk.
C:\Users\Nikolai\Downloads\node\deps\http_parser\http_parser.vcxproj(21,3): error MSB4019: The imported project "C:\Mic
rosoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the fil
e exists on disk.
C:\Users\Nikolai\Downloads\node\tools\icu\icu_implementation.vcxproj(21,3): error MSB4019: The imported project "C:\Mic
rosoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the fil
e exists on disk.
C:\Users\Nikolai\Downloads\node\tools\icu\icu_uconfig.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.
Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exist
s on disk.
C:\Users\Nikolai\Downloads\node\tools\icu\icu_uconfig_target.vcxproj(21,3): error MSB4019: The imported project "C:\Mic
rosoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the fil
e exists on disk.
C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\inspector_debugger_script.vcxproj(21,3): error MSB4019: The impor
ted project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correc
t, and that the file exists on disk.
C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\inspector_injected_script.vcxproj(21,3): error MSB4019: The impor
ted project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correc
t, and that the file exists on disk.
C:\Users\Nikolai\Downloads\node\deps\v8\src\js2c.vcxproj(29,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D
efault.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on
disk.
C:\Users\Nikolai\Downloads\node\deps\uv\libuv.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Defa
ult.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on dis
k.
C:\Users\Nikolai\Downloads\node\mkssldef.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.p
rops" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
C:\Users\Nikolai\Downloads\node\node_dtrace_header.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp
.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists o
n disk.
C:\Users\Nikolai\Downloads\node\node_dtrace_provider.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.C
pp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists
 on disk.
C:\Users\Nikolai\Downloads\node\node_dtrace_ustack.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp
.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists o
n disk.
C:\Users\Nikolai\Downloads\node\node_etw.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.p
rops" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
C:\Users\Nikolai\Downloads\node\node_js2c.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.
props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
C:\Users\Nikolai\Downloads\node\node_perfctr.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Defau
lt.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk
.
C:\Users\Nikolai\Downloads\node\deps\openssl\openssl.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.C
pp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists
 on disk.
C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\protocol_compatibility.vcxproj(21,3): error MSB4019: The imported
 project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct,
and that the file exists on disk.
C:\Users\Nikolai\Downloads\node\specialize_node_d.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.
Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on
 disk.
C:\Users\Nikolai\Downloads\node\v8_inspector_compress_protocol_json.vcxproj(21,3): error MSB4019: The imported project
"C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that
the file exists on disk.
C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libbase.vcxproj(29,3): error MSB4019: The imported project "C:\Microsoft
.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exis
ts on disk.
C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libplatform.vcxproj(29,3): error MSB4019: The imported project "C:\Micro
soft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file
exists on disk.
C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libsampler.vcxproj(29,3): error MSB4019: The imported project "C:\Micros
oft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file e
xists on disk.
C:\Users\Nikolai\Downloads\node\deps\zlib\zlib.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Def
ault.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on di
sk.
C:\Users\Nikolai\Downloads\node\deps\gtest\gtest.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D
efault.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on
disk.

Again, reopening cmd fixes that.

refack · 2017-06-06T11:27:58Z

@seishun thanks, could you paste the first few lines on output from vcbuild vs2017 (something like Looking for Visual Studio 2017... Found MSVS version 14.0)
(Anyway I'm setting up a testing environment with both VS2015 & VS2017, so I won't bug you too much 😉 )

P.S. even better if you remove the @echo off and paste all the noise

seishun · 2017-06-06T15:52:23Z

@refack Here you go:

C:\Users\Nikolai\Downloads\node>vcbuild vs2017
C:\Users\Nikolai\Downloads\node>cd C:\Users\Nikolai\Downloads\node\
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "help" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "--help" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "-help" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "/help" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "?" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "-?" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "--?" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "/?" goto help
C:\Users\Nikolai\Downloads\node>set config=Release
C:\Users\Nikolai\Downloads\node>set target=Build
C:\Users\Nikolai\Downloads\node>set target_arch=x64
C:\Users\Nikolai\Downloads\node>set target_env=vs2015
C:\Users\Nikolai\Downloads\node>set noprojgen=
C:\Users\Nikolai\Downloads\node>set nobuild=
C:\Users\Nikolai\Downloads\node>set sign=
C:\Users\Nikolai\Downloads\node>set nosnapshot=
C:\Users\Nikolai\Downloads\node>set cctest_args=
C:\Users\Nikolai\Downloads\node>set test_args=
C:\Users\Nikolai\Downloads\node>set package=
C:\Users\Nikolai\Downloads\node>set msi=
C:\Users\Nikolai\Downloads\node>set upload=
C:\Users\Nikolai\Downloads\node>set licensertf=
C:\Users\Nikolai\Downloads\node>set jslint=
C:\Users\Nikolai\Downloads\node>set cpplint=
C:\Users\Nikolai\Downloads\node>set build_testgc_addon=
C:\Users\Nikolai\Downloads\node>set noetw=
C:\Users\Nikolai\Downloads\node>set noetw_msi_arg=
C:\Users\Nikolai\Downloads\node>set noperfctr=
C:\Users\Nikolai\Downloads\node>set noperfctr_msi_arg=
C:\Users\Nikolai\Downloads\node>set i18n_arg=
C:\Users\Nikolai\Downloads\node>set download_arg=
C:\Users\Nikolai\Downloads\node>set build_release=
C:\Users\Nikolai\Downloads\node>set enable_vtune_arg=
C:\Users\Nikolai\Downloads\node>set configure_flags=
C:\Users\Nikolai\Downloads\node>set build_addons=
C:\Users\Nikolai\Downloads\node>set dll=
C:\Users\Nikolai\Downloads\node>set enable_static=
C:\Users\Nikolai\Downloads\node>set build_addons_napi=
C:\Users\Nikolai\Downloads\node>set test_node_inspect=
C:\Users\Nikolai\Downloads\node>set test_check_deopts=
C:\Users\Nikolai\Downloads\node>if "vs2017" == "" goto args-done
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "debug" set config=Debug  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "release" set config=Release  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "clean" set target=Clean  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "ia32" set target_arch=x86  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "x86" set target_arch=x86  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "x64" set target_arch=x64  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "vc2015" set target_env=vs2015  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "vs2015" set target_env=vs2015  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "vs2017" set target_env=vs2017  & goto arg-ok
C:\Users\Nikolai\Downloads\node>shift
C:\Users\Nikolai\Downloads\node>goto next-arg
C:\Users\Nikolai\Downloads\node>if "" == "" goto args-done
C:\Users\Nikolai\Downloads\node>if defined build_release (

set config=Release

set package=1

set msi=1

set licensertf=1

set download_arg="--download=all"

set i18n_arg=small-icu

)
C:\Users\Nikolai\Downloads\node>set "node_exe=Release\node.exe"
C:\Users\Nikolai\Downloads\node>if "Release" == "Debug" set configure_flags= --debug
C:\Users\Nikolai\Downloads\node>if defined nosnapshot set configure_flags= --without-snapshot
C:\Users\Nikolai\Downloads\node>if defined noetw set configure_flags= --without-etw  & set noetw_msi_arg=/p:NoETW=1
C:\Users\Nikolai\Downloads\node>if defined noperfctr set configure_flags= --without-perfctr  & set noperfctr_msi_arg=/p:NoPerfCtr=1
C:\Users\Nikolai\Downloads\node>if defined release_urlbase set configure_flags= --release-urlbase=
C:\Users\Nikolai\Downloads\node>if defined download_arg set configure_flags=
C:\Users\Nikolai\Downloads\node>if defined enable_vtune_arg set configure_flags= --enable-vtune-profiling
C:\Users\Nikolai\Downloads\node>if defined dll set configure_flags= --shared
C:\Users\Nikolai\Downloads\node>if defined enable_static set configure_flags= --enable-static
C:\Users\Nikolai\Downloads\node>if defined no_NODE_OPTIONS set configure_flags= --without-node-options
C:\Users\Nikolai\Downloads\node>if "" == "full-icu" set configure_flags= --with-intl=full-icu
C:\Users\Nikolai\Downloads\node>if "" == "small-icu" set configure_flags= --with-intl=small-icu
C:\Users\Nikolai\Downloads\node>if "" == "intl-none" set configure_flags= --with-intl=none
C:\Users\Nikolai\Downloads\node>if "" == "without-intl" set configure_flags= --without-intl
C:\Users\Nikolai\Downloads\node>if defined config_flags set configure_flags=
C:\Users\Nikolai\Downloads\node>if not exist "C:\Users\Nikolai\Downloads\node\deps\icu" goto no-depsicu
C:\Users\Nikolai\Downloads\node>call :getnodeversion   || exit /b 1
C:\Users\Nikolai\Downloads\node>set NODE_VERSION=
C:\Users\Nikolai\Downloads\node>set TAG=
C:\Users\Nikolai\Downloads\node>set FULLVERSION=
C:\Users\Nikolai\Downloads\node>for /F "usebackq tokens=*" %i in (python "C:\Users\Nikolai\Downloads\node\tools\getnodeversion.py") do set NODE_VERSION=%i
C:\Users\Nikolai\Downloads\node>set NODE_VERSION=9.0.0
C:\Users\Nikolai\Downloads\node>if not defined NODE_VERSION (

echo Cannot determine current version of Node.js

exit /b 1

)
C:\Users\Nikolai\Downloads\node>if not defined DISTTYPE set DISTTYPE=release
C:\Users\Nikolai\Downloads\node>if "release" == "release" (

set FULLVERSION=9.0.0

goto exit

)
C:\Users\Nikolai\Downloads\node>if not defined DISTTYPEDIR set DISTTYPEDIR=release
C:\Users\Nikolai\Downloads\node>goto :EOF
C:\Users\Nikolai\Downloads\node>if "Build" == "Clean" rmdir /Q /S "C:\Users\Nikolai\Downloads\node\Release\node-v9.0.0-win-x64"  1>nul 2>nul
C:\Users\Nikolai\Downloads\node>if defined noprojgen if defined nobuild if not defined sign if not defined msi goto licensertf
C:\Users\Nikolai\Downloads\node>set msvs_host_arch=x86
C:\Users\Nikolai\Downloads\node>if AMD64 == AMD64 set msvs_host_arch=amd64
C:\Users\Nikolai\Downloads\node>if __ == AMD64 set msvs_host_arch=amd64
C:\Users\Nikolai\Downloads\node>set vcvarsall_arg=amd64_x64
C:\Users\Nikolai\Downloads\node>if x64 == x64 if amd64 == amd64 set vcvarsall_arg=amd64
C:\Users\Nikolai\Downloads\node>if "vs2017" NEQ "vs2017" goto vs-set-2015
C:\Users\Nikolai\Downloads\node>echo Looking for Visual Studio 2017

Looking for Visual Studio 2017
C:\Users\Nikolai\Downloads\node>if "15.0" == "15.0" if "x64" == "x64" goto found_vs2017
C:\Users\Nikolai\Downloads\node>echo Found MSVS version 15.0

Found MSVS version 15.0
C:\Users\Nikolai\Downloads\node>set GYP_MSVS_VERSION=2017
C:\Users\Nikolai\Downloads\node>set PLATFORM_TOOLSET=v141
C:\Users\Nikolai\Downloads\node>goto msbuild-found
C:\Users\Nikolai\Downloads\node>if defined noprojgen goto msbuild
C:\Users\Nikolai\Downloads\node>echo configure  --dest-cpu=x64 --tag=

configure  --dest-cpu=x64 --tag=
C:\Users\Nikolai\Downloads\node>python configure  --dest-cpu=x64 --tag=

creating icu_config.gypi

Using ICU in deps/icu-small

creating icu_config.gypi

{ 'target_defaults': { 'cflags': [],

'default_configuration': 'Release',

'defines': [],

'include_dirs': [],

'libraries': []},

'variables': { 'asan': 0,

'coverage': 'false',

'debug_devtools': 'node',

'force_dynamic_crt': 0,

'host_arch': 'x64',

'icu_data_file': 'icudt59l.dat',

'icu_data_in': '..\..\deps/icu-small\source/data/in\icudt59l.dat',

'icu_endianness': 'l',

'icu_gyp_path': 'tools/icu/icu-generic.gyp',

'icu_locales': 'en,root',

'icu_path': 'deps/icu-small',

'icu_small': 'true',

'icu_ver_major': '59',

'node_byteorder': 'little',

'node_enable_d8': 'false',

'node_enable_v8_vtunejit': 'false',

'node_install_npm': 'true',

'node_module_version': 55,

'node_no_browser_globals': 'false',

'node_prefix': '/usr/local',

'node_release_urlbase': '',

'node_shared': 'false',

'node_shared_cares': 'false',

'node_shared_http_parser': 'false',

'node_shared_libuv': 'false',

'node_shared_openssl': 'false',

'node_shared_zlib': 'false',

'node_tag': '',

'node_use_bundled_v8': 'true',

'node_use_dtrace': 'false',

'node_use_etw': 'true',

'node_use_lttng': 'false',

'node_use_openssl': 'true',

'node_use_perfctr': 'true',

'node_use_v8_platform': 'true',

'node_without_node_options': 'false',

'openssl_fips': '',

'openssl_no_asm': 0,

'shlib_suffix': 'so.55',

'target_arch': 'x64',

'v8_enable_gdbjit': 0,

'v8_enable_i18n_support': 1,

'v8_enable_inspector': 1,

'v8_no_strict_aliasing': 1,

'v8_optimized_debug': 0,

'v8_promise_internal_field_count': 1,

'v8_random_seed': 0,

'v8_use_snapshot': 'true',

'want_separate_host_toolset': 0,

'want_separate_host_toolset_mkpeephole': 0}}

creating config.gypi

creating config.mk

Warning: Missing input files:

deps\v8\src....\include\v8-inspector-protocol.h

deps\v8\src....\include\v8-inspector.h

src\tracing\trace_event.hsrc\tree.h

C:\Users\Nikolai\Downloads\node>if errorlevel 1 goto create-msvs-files-failed
C:\Users\Nikolai\Downloads\node>if not exist node.sln goto create-msvs-files-failed
C:\Users\Nikolai\Downloads\node>echo Project files generated.

Project files generated.
C:\Users\Nikolai\Downloads\node>if defined nobuild goto sign
C:\Users\Nikolai\Downloads\node>set "msbcpu=/m:2"
C:\Users\Nikolai\Downloads\node>if "8" == "1" set "msbcpu=/m:1"
C:\Users\Nikolai\Downloads\node>set "msbplatform=Win32"
C:\Users\Nikolai\Downloads\node>if "x64" == "x64" set "msbplatform=x64"
C:\Users\Nikolai\Downloads\node>msbuild node.sln /m:2 /t:Build /p:Configuration=Release /p:Platform=x64 /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo

C:\Users\Nikolai\Downloads\node\deps\cares\cares.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D

efault.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on

disk.

C:\Users\Nikolai\Downloads\node\deps\http_parser\http_parser.vcxproj(21,3): error MSB4019: The imported project "C:\Mic

rosoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the fil

e exists on disk.

C:\Users\Nikolai\Downloads\node\tools\icu\icu_implementation.vcxproj(21,3): error MSB4019: The imported project "C:\Mic

rosoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the fil

e exists on disk.

C:\Users\Nikolai\Downloads\node\tools\icu\icu_uconfig.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.

Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exist

s on disk.

C:\Users\Nikolai\Downloads\node\tools\icu\icu_uconfig_target.vcxproj(21,3): error MSB4019: The imported project "C:\Mic

rosoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the fil

e exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\inspector_debugger_script.vcxproj(21,3): error MSB4019: The impor

ted project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correc

t, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\inspector_injected_script.vcxproj(21,3): error MSB4019: The impor

ted project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correc

t, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\js2c.vcxproj(29,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D

efault.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on

disk.

C:\Users\Nikolai\Downloads\node\deps\uv\libuv.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Defa

ult.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on dis

k.

C:\Users\Nikolai\Downloads\node\mkssldef.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.p

rops" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\node_dtrace_header.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp

.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists o

n disk.

C:\Users\Nikolai\Downloads\node\node_dtrace_provider.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.C

pp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists

on disk.

C:\Users\Nikolai\Downloads\node\node_dtrace_ustack.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp

.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists o

n disk.

C:\Users\Nikolai\Downloads\node\node_etw.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.p

rops" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\node_js2c.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.

props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\node_perfctr.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Defau

lt.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk

.

C:\Users\Nikolai\Downloads\node\deps\openssl\openssl.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.C

pp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists

on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\protocol_compatibility.vcxproj(21,3): error MSB4019: The imported

project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct,

and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\specialize_node_d.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.

Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on

disk.

C:\Users\Nikolai\Downloads\node\v8_inspector_compress_protocol_json.vcxproj(21,3): error MSB4019: The imported project

"C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that

the file exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libbase.vcxproj(29,3): error MSB4019: The imported project "C:\Microsoft

.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exis

ts on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libplatform.vcxproj(29,3): error MSB4019: The imported project "C:\Micro

soft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file

exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libsampler.vcxproj(29,3): error MSB4019: The imported project "C:\Micros

oft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file e

xists on disk.

C:\Users\Nikolai\Downloads\node\deps\zlib\zlib.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Def

ault.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on di

sk.

C:\Users\Nikolai\Downloads\node\deps\gtest\gtest.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D

efault.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on

disk.
C:\Users\Nikolai\Downloads\node>if errorlevel 1 goto exit
C:\Users\Nikolai\Downloads\node>goto :EOF

(Is there a way to collapse text on GitHub?)

[refack edited formating]

refack · 2017-06-06T16:02:42Z

10x

(Is there a way to collapse text on GitHub?)

Wrap in <details><code><pre>...</pre></code></detail>
_{just edited your comment}

kunalspathak · 2017-06-06T22:27:07Z

I am able to repro this problem. For me the ToolsVersion is 15.0 and I don't see that version's entry inside registry so it is defaulting to current working directory to find Microsoft.Cpp.Default.props.
@refack - Do you know if this has changed with VS2017?

Source: https://stackoverflow.com/questions/35623640/how-to-find-out-where-vctargetspath-value-in-visual-studio-2012-comes-from#comment58931231_35623640

refack · 2017-06-06T22:37:08Z

@refack - Do you know if this has changed with VS2017?

Yep:

Don't know where they hide the pointer now.

refack · 2017-06-06T22:47:17Z

I added another guard, but I can't test it right now...

seishun · 2017-06-07T07:03:33Z

@refack Still the same error.

C:\Users\Nikolai\Downloads\node>vcbuild vs2017
C:\Users\Nikolai\Downloads\node>cd C:\Users\Nikolai\Downloads\node\
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "help" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "--help" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "-help" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "/help" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "?" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "-?" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "--?" goto help
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "/?" goto help
C:\Users\Nikolai\Downloads\node>set config=Release
C:\Users\Nikolai\Downloads\node>set target=Build
C:\Users\Nikolai\Downloads\node>set target_arch=x64
C:\Users\Nikolai\Downloads\node>set target_env=vs2015
C:\Users\Nikolai\Downloads\node>set noprojgen=
C:\Users\Nikolai\Downloads\node>set nobuild=
C:\Users\Nikolai\Downloads\node>set sign=
C:\Users\Nikolai\Downloads\node>set nosnapshot=
C:\Users\Nikolai\Downloads\node>set cctest_args=
C:\Users\Nikolai\Downloads\node>set test_args=
C:\Users\Nikolai\Downloads\node>set package=
C:\Users\Nikolai\Downloads\node>set msi=
C:\Users\Nikolai\Downloads\node>set upload=
C:\Users\Nikolai\Downloads\node>set licensertf=
C:\Users\Nikolai\Downloads\node>set jslint=
C:\Users\Nikolai\Downloads\node>set cpplint=
C:\Users\Nikolai\Downloads\node>set build_testgc_addon=
C:\Users\Nikolai\Downloads\node>set noetw=
C:\Users\Nikolai\Downloads\node>set noetw_msi_arg=
C:\Users\Nikolai\Downloads\node>set noperfctr=
C:\Users\Nikolai\Downloads\node>set noperfctr_msi_arg=
C:\Users\Nikolai\Downloads\node>set i18n_arg=
C:\Users\Nikolai\Downloads\node>set download_arg=
C:\Users\Nikolai\Downloads\node>set build_release=
C:\Users\Nikolai\Downloads\node>set enable_vtune_arg=
C:\Users\Nikolai\Downloads\node>set configure_flags=
C:\Users\Nikolai\Downloads\node>set build_addons=
C:\Users\Nikolai\Downloads\node>set dll=
C:\Users\Nikolai\Downloads\node>set enable_static=
C:\Users\Nikolai\Downloads\node>set build_addons_napi=
C:\Users\Nikolai\Downloads\node>set test_node_inspect=
C:\Users\Nikolai\Downloads\node>set test_check_deopts=
C:\Users\Nikolai\Downloads\node>if "vs2017" == "" goto args-done
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "debug" set config=Debug  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "release" set config=Release  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "clean" set target=Clean  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "ia32" set target_arch=x86  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "x86" set target_arch=x86  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "x64" set target_arch=x64  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "vc2015" set target_env=vs2015  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "vs2015" set target_env=vs2015  & goto arg-ok
C:\Users\Nikolai\Downloads\node>if /I "vs2017" == "vs2017" set target_env=vs2017  & goto arg-ok
C:\Users\Nikolai\Downloads\node>shift
C:\Users\Nikolai\Downloads\node>goto next-arg
C:\Users\Nikolai\Downloads\node>if "" == "" goto args-done
C:\Users\Nikolai\Downloads\node>if defined build_release (

set config=Release

set package=1

set msi=1

set licensertf=1

set download_arg="--download=all"

set i18n_arg=small-icu

)
C:\Users\Nikolai\Downloads\node>set "node_exe=Release\node.exe"
C:\Users\Nikolai\Downloads\node>if "Release" == "Debug" set configure_flags= --debug
C:\Users\Nikolai\Downloads\node>if defined nosnapshot set configure_flags= --without-snapshot
C:\Users\Nikolai\Downloads\node>if defined noetw set configure_flags= --without-etw  & set noetw_msi_arg=/p:NoETW=1
C:\Users\Nikolai\Downloads\node>if defined noperfctr set configure_flags= --without-perfctr  & set noperfctr_msi_arg=/p:NoPerfCtr=1
C:\Users\Nikolai\Downloads\node>if defined release_urlbase set configure_flags= --release-urlbase=
C:\Users\Nikolai\Downloads\node>if defined download_arg set configure_flags=
C:\Users\Nikolai\Downloads\node>if defined enable_vtune_arg set configure_flags= --enable-vtune-profiling
C:\Users\Nikolai\Downloads\node>if defined dll set configure_flags= --shared
C:\Users\Nikolai\Downloads\node>if defined enable_static set configure_flags= --enable-static
C:\Users\Nikolai\Downloads\node>if defined no_NODE_OPTIONS set configure_flags= --without-node-options
C:\Users\Nikolai\Downloads\node>if "" == "full-icu" set configure_flags= --with-intl=full-icu
C:\Users\Nikolai\Downloads\node>if "" == "small-icu" set configure_flags= --with-intl=small-icu
C:\Users\Nikolai\Downloads\node>if "" == "intl-none" set configure_flags= --with-intl=none
C:\Users\Nikolai\Downloads\node>if "" == "without-intl" set configure_flags= --without-intl
C:\Users\Nikolai\Downloads\node>if defined config_flags set configure_flags=
C:\Users\Nikolai\Downloads\node>if not exist "C:\Users\Nikolai\Downloads\node\deps\icu" goto no-depsicu
C:\Users\Nikolai\Downloads\node>call :getnodeversion   || exit /b 1
C:\Users\Nikolai\Downloads\node>set NODE_VERSION=
C:\Users\Nikolai\Downloads\node>set TAG=
C:\Users\Nikolai\Downloads\node>set FULLVERSION=
C:\Users\Nikolai\Downloads\node>for /F "usebackq tokens=*" %i in (python "C:\Users\Nikolai\Downloads\node\tools\getnodeversion.py") do set NODE_VERSION=%i
C:\Users\Nikolai\Downloads\node>set NODE_VERSION=9.0.0
C:\Users\Nikolai\Downloads\node>if not defined NODE_VERSION (

echo Cannot determine current version of Node.js

exit /b 1

)
C:\Users\Nikolai\Downloads\node>if not defined DISTTYPE set DISTTYPE=release
C:\Users\Nikolai\Downloads\node>if "release" == "release" (

set FULLVERSION=9.0.0

goto exit

)
C:\Users\Nikolai\Downloads\node>if not defined DISTTYPEDIR set DISTTYPEDIR=release
C:\Users\Nikolai\Downloads\node>goto :EOF
C:\Users\Nikolai\Downloads\node>if "Build" == "Clean" rmdir /Q /S "C:\Users\Nikolai\Downloads\node\Release\node-v9.0.0-win-x64"  1>nul 2>nul
C:\Users\Nikolai\Downloads\node>if defined noprojgen if defined nobuild if not defined sign if not defined msi goto licensertf
C:\Users\Nikolai\Downloads\node>set msvs_host_arch=x86
C:\Users\Nikolai\Downloads\node>if AMD64 == AMD64 set msvs_host_arch=amd64
C:\Users\Nikolai\Downloads\node>if __ == AMD64 set msvs_host_arch=amd64
C:\Users\Nikolai\Downloads\node>set vcvarsall_arg=amd64_x64
C:\Users\Nikolai\Downloads\node>if x64 == x64 if amd64 == amd64 set vcvarsall_arg=amd64
C:\Users\Nikolai\Downloads\node>if "vs2017" NEQ "vs2017" goto vs-set-2015
C:\Users\Nikolai\Downloads\node>echo Looking for Visual Studio 2017

Looking for Visual Studio 2017
C:\Users\Nikolai\Downloads\node>if defined VCToolsInstallDir if "15.0.26430.12" == "15.0" if "x64" == "x64" goto found_vs2017
C:\Users\Nikolai\Downloads\node>call tools\msvs\vswhere_usability_wrapper.cmd

calling: "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" amd64

** Visual Studio 2017 Developer Command Prompt v15.0.26430.12

** Copyright (c) 2017 Microsoft Corporation

[ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***

Found MSVS version 15.0

configure  --dest-cpu=x64 --tag=

creating icu_config.gypi

Using ICU in deps/icu-small

creating icu_config.gypi

{ 'target_defaults': { 'cflags': [],

'default_configuration': 'Release',

'defines': [],

'include_dirs': [],

'libraries': []},

'variables': { 'asan': 0,

'coverage': 'false',

'debug_devtools': 'node',

'force_dynamic_crt': 0,

'host_arch': 'x64',

'icu_data_file': 'icudt59l.dat',

'icu_data_in': '..\..\deps/icu-small\source/data/in\icudt59l.dat',

'icu_endianness': 'l',

'icu_gyp_path': 'tools/icu/icu-generic.gyp',

'icu_locales': 'en,root',

'icu_path': 'deps/icu-small',

'icu_small': 'true',

'icu_ver_major': '59',

'node_byteorder': 'little',

'node_enable_d8': 'false',

'node_enable_v8_vtunejit': 'false',

'node_install_npm': 'true',

'node_module_version': 55,

'node_no_browser_globals': 'false',

'node_prefix': '/usr/local',

'node_release_urlbase': '',

'node_shared': 'false',

'node_shared_cares': 'false',

'node_shared_http_parser': 'false',

'node_shared_libuv': 'false',

'node_shared_openssl': 'false',

'node_shared_zlib': 'false',

'node_tag': '',

'node_use_bundled_v8': 'true',

'node_use_dtrace': 'false',

'node_use_etw': 'true',

'node_use_lttng': 'false',

'node_use_openssl': 'true',

'node_use_perfctr': 'true',

'node_use_v8_platform': 'true',

'node_without_node_options': 'false',

'openssl_fips': '',

'openssl_no_asm': 0,

'shlib_suffix': 'so.55',

'target_arch': 'x64',

'v8_enable_gdbjit': 0,

'v8_enable_i18n_support': 1,

'v8_enable_inspector': 1,

'v8_no_strict_aliasing': 1,

'v8_optimized_debug': 0,

'v8_promise_internal_field_count': 1,

'v8_random_seed': 0,

'v8_use_snapshot': 'true',

'want_separate_host_toolset': 0,

'want_separate_host_toolset_mkpeephole': 0}}

creating config.gypi

creating config.mk

Warning: Missing input files:

deps\v8\src....\include\v8-inspector-protocol.h

deps\v8\src....\include\v8-inspector.h

src\tracing\trace_event.hsrc\tree.h

Project files generated.

C:\Users\Nikolai\Downloads\node\deps\cares\cares.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D

efault.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on

disk.

C:\Users\Nikolai\Downloads\node\deps\http_parser\http_parser.vcxproj(21,3): error MSB4019: The imported project "C:\Mic

rosoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the fil

e exists on disk.

C:\Users\Nikolai\Downloads\node\tools\icu\icu_implementation.vcxproj(21,3): error MSB4019: The imported project "C:\Mic

rosoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the fil

e exists on disk.

C:\Users\Nikolai\Downloads\node\tools\icu\icu_uconfig.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.

Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exist

s on disk.

C:\Users\Nikolai\Downloads\node\tools\icu\icu_uconfig_target.vcxproj(21,3): error MSB4019: The imported project "C:\Mic

rosoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the fil

e exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\inspector_debugger_script.vcxproj(21,3): error MSB4019: The impor

ted project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correc

t, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\inspector_injected_script.vcxproj(21,3): error MSB4019: The impor

ted project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correc

t, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\js2c.vcxproj(29,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D

efault.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on

disk.

C:\Users\Nikolai\Downloads\node\deps\uv\libuv.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Defa

ult.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on dis

k.

C:\Users\Nikolai\Downloads\node\mkssldef.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.p

rops" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\node_dtrace_header.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp

.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists o

n disk.

C:\Users\Nikolai\Downloads\node\node_dtrace_provider.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.C

pp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists

on disk.

C:\Users\Nikolai\Downloads\node\node_dtrace_ustack.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp

.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists o

n disk.

C:\Users\Nikolai\Downloads\node\node_etw.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.p

rops" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\node_js2c.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.

props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\node_perfctr.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Defau

lt.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk

.

C:\Users\Nikolai\Downloads\node\deps\openssl\openssl.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.C

pp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists

on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\inspector\protocol_compatibility.vcxproj(21,3): error MSB4019: The imported

project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct,

and that the file exists on disk.

C:\Users\Nikolai\Downloads\node\specialize_node_d.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.

Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on

disk.

C:\Users\Nikolai\Downloads\node\v8_inspector_compress_protocol_json.vcxproj(21,3): error MSB4019: The imported project

"C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that

the file exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libbase.vcxproj(29,3): error MSB4019: The imported project "C:\Microsoft

.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exis

ts on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libplatform.vcxproj(29,3): error MSB4019: The imported project "C:\Micro

soft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file

exists on disk.

C:\Users\Nikolai\Downloads\node\deps\v8\src\v8_libsampler.vcxproj(29,3): error MSB4019: The imported project "C:\Micros

oft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file e

xists on disk.

C:\Users\Nikolai\Downloads\node\deps\zlib\zlib.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Def

ault.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on di

sk.

C:\Users\Nikolai\Downloads\node\deps\gtest\gtest.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.D

efault.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on

disk.

C:\Users\Nikolai\Downloads\node>

refack · 2017-06-07T10:47:45Z

@seishun looks like something is wonky with your VS2017 version:

C:\Users\Nikolai\Downloads\node>if defined VCToolsInstallDir if "_15.0.26430.12_" == "_15.0_" if "_x64_" == "_x64_" goto found_vs2017

C:\Users\Nikolai\Downloads\node>call tools\msvs\vswhere_usability_wrapper.cmd
calling: "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2017 Developer Command Prompt v15.0.26430.12
** Copyright (c) 2017 Microsoft Corporation
**********************************************************************
[ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***

If you run vcbuild vs2017 in a clean environment does it work?

Could you try running repair in the VS Studio installer?

seishun · 2017-06-07T11:02:00Z

It works just fine if I reopen cmd.

Were you unable to reproduce this in your environment?

refack · 2017-06-07T12:40:24Z

No, but I get
if defined VCToolsInstallDir if "_14.0_" == "_15.0_" if "_x64_" == "_x64_" goto found_vs2017 not 15.0.26430.12
So maybe something is wonky with my VS Build Tools 2015

joaocgreis · 2017-06-07T18:34:09Z

@refack this seems to fix it for me, feel free to add it if it lgty:

--- a/vcbuild.bat
+++ b/vcbuild.bat
@@ -167,6 +167,7 @@ echo Looking for Visual Studio 2017
 if "_%VSCMD_ARG_TGT_ARCH%_"=="_%target_arch%_" goto found_vs2017
 call tools\msvs\vswhere_usability_wrapper.cmd
 if "_%VCINSTALLDIR%_" == "__" goto vs-set-2015
+set "VSINSTALLDIR="
 set vcvars_call="%VCINSTALLDIR%\Auxiliary\Build\vcvarsall.bat" %vcvarsall_arg%
 echo calling: %vcvars_call%
 call %vcvars_call%

refack · 2017-06-07T22:45:50Z

@refack this seems to fix it for me, feel free to add it if it lgty:

~~So it's a vs2017 => vs2015 => vs2017 situation 💡~~
No, It's a vcvarsall bug

PR-URL: nodejs#13485 Fixes: nodejs#13398 Reviewed-By: James M Snell <[email protected]>

refack · 2017-06-10T21:00:15Z

Landed in 780acc2

PR-URL: #13485 Fixes: #13398 Reviewed-By: James M Snell <[email protected]>

MylesBorins · 2017-07-17T18:22:51Z

Should this land on v6.x?

MylesBorins · 2017-09-19T15:56:45Z

ping @refack

MylesBorins · 2017-11-14T18:55:13Z

ping @refack

refack · 2017-11-14T19:05:09Z

@MylesBorins v6.x doesn't have any support for VS2017 yet, so this change alone is a noop.

AFAIK there were no issues opened for VS2017 support for v6.x, and the CI/release infra is setup for VS2015 so my estimation is it's not needed.

nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jun 5, 2017

refack force-pushed the allow-force-vs2017 branch from 20d804d to eb26d19 Compare June 5, 2017 21:47

refack mentioned this pull request Jun 5, 2017

Unable to build with VS2017 after building with VS2015 #13398

Closed

jasnell approved these changes Jun 5, 2017

View reviewed changes

refack added the wip Issues and PRs that are still a work in progress. label Jun 6, 2017

refack self-assigned this Jun 6, 2017

refack removed the wip Issues and PRs that are still a work in progress. label Jun 10, 2017

build,windows: check for VS version and arch

780acc2

PR-URL: nodejs#13485 Fixes: nodejs#13398 Reviewed-By: James M Snell <[email protected]>

refack force-pushed the allow-force-vs2017 branch from dcc1fcd to 780acc2 Compare June 10, 2017 20:57

refack merged commit 780acc2 into nodejs:master Jun 10, 2017

refack deleted the allow-force-vs2017 branch June 10, 2017 21:24

refack removed their assignment Jun 12, 2017

addaleax pushed a commit that referenced this pull request Jun 12, 2017

build,windows: check for VS version and arch

00d2f7c

PR-URL: #13485 Fixes: #13398 Reviewed-By: James M Snell <[email protected]>

addaleax mentioned this pull request Jun 12, 2017

v8.1.1 proposal #13598

Merged

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added the lts-watch-v6.x label Jul 17, 2017

refack added dont-land-on-v6.x and removed lts-watch-v6.x labels Nov 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build,windows: check for VS version and arch #13485

build,windows: check for VS version and arch #13485

refack commented Jun 5, 2017

refack commented Jun 5, 2017

refack commented Jun 5, 2017

digitalinfinity commented Jun 6, 2017

seishun commented Jun 6, 2017 •

edited

Loading

refack commented Jun 6, 2017 •

edited

Loading

seishun commented Jun 6, 2017 •

edited by refack

Loading

refack commented Jun 6, 2017 •

edited

Loading

kunalspathak commented Jun 6, 2017 •

edited

Loading

refack commented Jun 6, 2017

refack commented Jun 6, 2017

seishun commented Jun 7, 2017 •

edited

Loading

refack commented Jun 7, 2017

seishun commented Jun 7, 2017

refack commented Jun 7, 2017 •

edited

Loading

joaocgreis commented Jun 7, 2017

refack commented Jun 7, 2017 •

edited

Loading

refack commented Jun 10, 2017

MylesBorins commented Jul 17, 2017

MylesBorins commented Sep 19, 2017

MylesBorins commented Nov 14, 2017

refack commented Nov 14, 2017

build,windows: check for VS version and arch #13485

build,windows: check for VS version and arch #13485

Conversation

refack commented Jun 5, 2017

Checklist

Affected core subsystem(s)

refack commented Jun 5, 2017

refack commented Jun 5, 2017

digitalinfinity commented Jun 6, 2017

seishun commented Jun 6, 2017 • edited Loading

refack commented Jun 6, 2017 • edited Loading

seishun commented Jun 6, 2017 • edited by refack Loading

refack commented Jun 6, 2017 • edited Loading

kunalspathak commented Jun 6, 2017 • edited Loading

refack commented Jun 6, 2017

refack commented Jun 6, 2017

seishun commented Jun 7, 2017 • edited Loading

refack commented Jun 7, 2017

seishun commented Jun 7, 2017

refack commented Jun 7, 2017 • edited Loading

joaocgreis commented Jun 7, 2017

refack commented Jun 7, 2017 • edited Loading

refack commented Jun 10, 2017

MylesBorins commented Jul 17, 2017

MylesBorins commented Sep 19, 2017

MylesBorins commented Nov 14, 2017

refack commented Nov 14, 2017

seishun commented Jun 6, 2017 •

edited

Loading

refack commented Jun 6, 2017 •

edited

Loading

seishun commented Jun 6, 2017 •

edited by refack

Loading

refack commented Jun 6, 2017 •

edited

Loading

kunalspathak commented Jun 6, 2017 •

edited

Loading

seishun commented Jun 7, 2017 •

edited

Loading

refack commented Jun 7, 2017 •

edited

Loading

refack commented Jun 7, 2017 •

edited

Loading