Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: add missing ERR_ prefix on util.callbackify error #13604

Closed
wants to merge 1 commit into from
Closed

errors: add missing ERR_ prefix on util.callbackify error #13604

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jun 11, 2017 •
edited
Loading

The FALSY_VALUE_REJECTION error code added by #12712 did not have the ERR_ prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency.

#12712 is a semver-minor but it has not yet been shipped in a release. If it had been shipped, then this PR would have had to been semver-major. This should land in a release the same time as af3aa68

/cc @refack @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

util, errors

@jasnell
errors: add missing ERR_ prefix on util.callbackify error
4ed4fa4 
The `FALSY_VALUE_REJECTION` error code added by
nodejs#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. util Issues and PRs related to the built-in util module. labels Jun 11, 2017
@jasnell jasnell requested a review from refack June 11, 2017 03:36
addaleax
addaleax approved these changes Jun 11, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, I think it’s okay to fast-track this (edit: to be clear, fast-track to be sure they get in the same release, not because I’d include it in #13598)

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/10500/

@refack
Copy link
Contributor

refack commented Jun 11, 2017

Just for my information, why is this important?
(particularly in this case where the Error is not exactly an error?)

@jasnell
Copy link
Member Author

jasnell commented Jun 11, 2017

@refack ... Largely for sake of consistency.

@jasnell
Copy link
Member Author

jasnell commented Jun 11, 2017

Failures in CI are concerning but are not related to this change

@refack
Copy link
Contributor

refack commented Jun 11, 2017

arm failure: #13603
aix failure: #13577

Rerun (just in case)
arm-fanned: https://ci.nodejs.org/job/node-test-commit-arm-fanned/9350/

jasnell added a commit that referenced this pull request Jun 13, 2017
@jasnell
errors: add missing ERR_ prefix on util.callbackify error
873e2f2 
The `FALSY_VALUE_REJECTION` error code added by
#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

PR-URL: #13604
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Jun 13, 2017

Landed in 873e2f2

@jasnell jasnell closed this Jun 13, 2017
refack pushed a commit to refack/node that referenced this pull request Jun 17, 2017
@jasnell @refack
errors: add missing ERR_ prefix on util.callbackify error
3643483 
The `FALSY_VALUE_REJECTION` error code added by
nodejs#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

PR-URL: nodejs#13604
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@refack refack mentioned this pull request Jun 17, 2017
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Jun 20, 2017
@jasnell @addaleax
errors: add missing ERR_ prefix on util.callbackify error
eb6817d 
The `FALSY_VALUE_REJECTION` error code added by
#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

Original-PR-URL: #13604
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Timothy Gu <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>
Original-Reviewed-By: Anna Henningsen <[email protected]>
Original-Reviewed-By: Refael Ackermann <[email protected]>
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #13750
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@jasnell @addaleax
errors: add missing ERR_ prefix on util.callbackify error
ed01bfe 
The `FALSY_VALUE_REJECTION` error code added by
#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

Original-PR-URL: #13604
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Timothy Gu <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>
Original-Reviewed-By: Anna Henningsen <[email protected]>
Original-Reviewed-By: Refael Ackermann <[email protected]>
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #13750
Reviewed-By: Anna Henningsen <[email protected]>
tniessen added a commit to tniessen/node that referenced this pull request Jun 22, 2017
@tniessen
doc: unify ERR_FALSY_VALUE_REJECTION description
118fd32 
Refs: nodejs#13604
Refs: nodejs#13627
@tniessen tniessen mentioned this pull request Jun 22, 2017
Closed
2 tasks
addaleax pushed a commit that referenced this pull request Jun 24, 2017
@jasnell @addaleax
errors: add missing ERR_ prefix on util.callbackify error
efaa03c 
The `FALSY_VALUE_REJECTION` error code added by
#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

Original-PR-URL: #13604
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Timothy Gu <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>
Original-Reviewed-By: Anna Henningsen <[email protected]>
Original-Reviewed-By: Refael Ackermann <[email protected]>
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #13750
Reviewed-By: Anna Henningsen <[email protected]>
tniessen added a commit that referenced this pull request Jun 28, 2017
@tniessen
doc: unify ERR_FALSY_VALUE_REJECTION description
23b3bbf 
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 29, 2017
@jasnell @rvagg
errors: add missing ERR_ prefix on util.callbackify error
508a822 
The `FALSY_VALUE_REJECTION` error code added by
#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

Original-PR-URL: #13604
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Timothy Gu <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>
Original-Reviewed-By: Anna Henningsen <[email protected]>
Original-Reviewed-By: Refael Ackermann <[email protected]>
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #13750
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 29, 2017
@tniessen @addaleax
doc: unify ERR_FALSY_VALUE_REJECTION description
6657c4c 
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@jasnell @addaleax
errors: add missing ERR_ prefix on util.callbackify error
0264a3a 
The `FALSY_VALUE_REJECTION` error code added by
#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

Original-PR-URL: #13604
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Timothy Gu <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>
Original-Reviewed-By: Anna Henningsen <[email protected]>
Original-Reviewed-By: Refael Ackermann <[email protected]>
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #13750
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@tniessen @addaleax
doc: unify ERR_FALSY_VALUE_REJECTION description
a95b7de 
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@jasnell @addaleax
errors: add missing ERR_ prefix on util.callbackify error
e8780ba 
The `FALSY_VALUE_REJECTION` error code added by
#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

Original-PR-URL: #13604
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Timothy Gu <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>
Original-Reviewed-By: Anna Henningsen <[email protected]>
Original-Reviewed-By: Refael Ackermann <[email protected]>
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #13750
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@tniessen @addaleax
doc: unify ERR_FALSY_VALUE_REJECTION description
0fc7a50 
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jasnell @addaleax @refack @benjamingr @lpinca @TimothyGu @cjihrig @gibfahn @MylesBorins @nodejs-github-bot