build: remove dependency on icu io library #13656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
@srl295 Apropos tools/icu/patches, am I right the 54 and 55 directories can be deleted? Building against those versions doesn't work any more, AFAIK, or does it? |
jasnell
approved these changes
Jun 13, 2017
srl295
requested changes
Jun 13, 2017
It should still work. |
srl295
previously requested changes
Jun 13, 2017
There was a problem hiding this comment.
Please add 'io' to https://github.com/nodejs/node/blob/master/tools/icu/shrink-icu-src.py#L57 (next to layoutex etc )
The library is only used in a single build-time tool where it can be easily substituted by regular libc I/O functions.
The previous commit removed the dependency on the code in that directory. This commit removes the directory itself and shrinks the source tarball by about 200 kB.
|
@srl295 Updated. Am I right that file is only run manually? I.e., not as part of any build step? |
refack
approved these changes
Jun 21, 2017
|
Windows fail looks like infra, rerun: https://ci.nodejs.org/job/node-test-commit-windows-fanned/9948/ |
cjihrig
approved these changes
Jun 22, 2017
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jun 26, 2017
The library is only used in a single build-time tool where it can be easily substituted by regular libc I/O functions. PR-URL: nodejs#13656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jun 26, 2017
The previous commit removed the dependency on the code in that directory. This commit removes the directory itself and shrinks the source tarball by about 200 kB. PR-URL: nodejs#13656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Landed in 87d682b...6bf4c23, cheers. |
addaleax
pushed a commit
that referenced
this pull request
Jun 29, 2017
The library is only used in a single build-time tool where it can be easily substituted by regular libc I/O functions. PR-URL: #13656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 29, 2017
The previous commit removed the dependency on the code in that directory. This commit removes the directory itself and shrinks the source tarball by about 200 kB. PR-URL: #13656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
The library is only used in a single build-time tool where it can be easily substituted by regular libc I/O functions. PR-URL: #13656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
The previous commit removed the dependency on the code in that directory. This commit removes the directory itself and shrinks the source tarball by about 200 kB. PR-URL: #13656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
The library is only used in a single build-time tool where it can be easily substituted by regular libc I/O functions. PR-URL: #13656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
The previous commit removed the dependency on the code in that directory. This commit removes the directory itself and shrinks the source tarball by about 200 kB. PR-URL: #13656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Should this be backported to |
srl295
reviewed
Aug 30, 2017
| @@ -56,6 +56,7 @@ def icu_ignore(dir, files): | |||
| elif subdir == 'source': | |||
| ign = ign + ['layout','samples','test','extra','config','layoutex','allinone','data'] | |||
| ign = ign + ['runConfigureICU','install-sh','mkinstalldirs','configure'] | |||
| ign = ign + ['io'] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library is only used in a single build-time tool where it can be
easily substituted by regular libc I/O functions.
Split into two commits for easier review.
CI: https://ci.nodejs.org/job/node-test-pull-request/8629/CI: https://ci.nodejs.org/job/node-test-pull-request/8630/