Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: support extra contexts when connected #13826

Closed
wants to merge 2 commits into from
Closed

inspector: support extra contexts when connected #13826

wants to merge 2 commits into from

Commits on Jun 20, 2017

  1. inspector: support extra contexts 

    This enables inspector support for contexts created using the vm
module.

Fixes: nodejs#7593
Fixes: nodejs#12096
Refs: nodejs#9272
    @jgoz
    Eugene Ostroukhov authored and jgoz committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    a4d4715 View commit details
    Browse the repository at this point in the history

  2. inspector: only call contextCreated if connected 

    In contextCreated, V8Inspector wraps contexts with InspectedContext,
which adds "global" and "console" to each context. This breaks the
vm-test-basic tests and may lead to unexpected behaviour outside of
inspector sessions.

Calling contextCreated only if the inspector is actually connected
ensures that this behaviour is limited to active inspector sessions.
    @jgoz
    jgoz committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    3c28258 View commit details
    Browse the repository at this point in the history