Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary import #13855

Closed
wants to merge 1 commit into from
Closed

test: remove unnecessary import #13855

wants to merge 1 commit into from

Conversation

OriLev
Copy link
Contributor

@OriLev OriLev commented Jun 21, 2017

#goodnessSquad

This is my first node contribution

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 21, 2017
const buffer = require('buffer');
const Buffer = buffer.Buffer;
const SlowBuffer = buffer.SlowBuffer;
const SlowBuffer = require('buffer').SlowBuffer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const { SlowBuffer } = require('buffer') can also be used.

@vsemozhetbyt
Copy link
Contributor

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Jun 21, 2017
aqrln pushed a commit to aqrln/node that referenced this pull request Jun 24, 2017
Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: nodejs#13836
PR-URL: nodejs#13855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aqrln
Copy link
Contributor

aqrln commented Jun 24, 2017

Landed in 22ccbe6. Thanks for your contribution!

@aqrln aqrln closed this Jun 24, 2017
addaleax pushed a commit that referenced this pull request Jun 24, 2017
Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: #13836
PR-URL: #13855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jun 24, 2017
addaleax pushed a commit that referenced this pull request Jun 29, 2017
Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: #13836
PR-URL: #13855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: #13836
PR-URL: #13855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: #13836
PR-URL: #13855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: #13836
PR-URL: #13855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: #13836
PR-URL: #13855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: #13836
PR-URL: #13855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants