n-api: add napi_delete_element() #13949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasongin
approved these changes
Jun 27, 2017
Refs: nodejs#13924 PR-URL: nodejs#13949 Reviewed-By: Jason Ginchereau <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 3, 2017
Refs: nodejs#13924 PR-URL: nodejs#13949 Reviewed-By: Jason Ginchereau <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
Refs: #13924 PR-URL: #13949 Reviewed-By: Jason Ginchereau <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Refs: #13924 PR-URL: #13949 Reviewed-By: Jason Ginchereau <[email protected]>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Refs: nodejs#13924 PR-URL: nodejs#13949 Reviewed-By: Jason Ginchereau <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Refs: #13924 Backport-PR-URL: #19447 PR-URL: #13949 Reviewed-By: Jason Ginchereau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #13924
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api