Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: backport 1f8555 from v8's upstream #1395

Closed
wants to merge 2 commits into from
Closed

deps: backport 1f8555 from v8's upstream #1395

wants to merge 2 commits into from

Commits on Apr 11, 2015

  1. deps: backport 1f8555 from v8's upstream 

    Original commit message:

    api: introduce SealHandleScope

    When debugging Handle leaks in io.js we found it very convenient to be
    able to Seal some specific (root in our case) scope to prevent Handle
    allocations in it, and easily find leakage.

    R=yangguo
    BUG=

    Review URL: https://codereview.chromium.org/1079713002

    Cr-Commit-Position: refs/heads/master@{nodejs#27766}

Should help us identify and fix Handle leaks in core and user-space code.

NOTE: Works only in Debug build now, but is still better than nothing.
    @indutny
    indutny committed Apr 11, 2015
    Configuration menu
    Copy the full SHA
    7e2fa21 View commit details
    Browse the repository at this point in the history

  2. src: use global SealHandleScope 

    Helps to find Handle leaks in Debug mode.
    @indutny
    indutny committed Apr 11, 2015
    Configuration menu
    Copy the full SHA
    004cba0 View commit details
    Browse the repository at this point in the history