Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,fs: delay unlink in test-regress-GH-4027.js #14010

Closed
wants to merge 2 commits into from
Closed

test,fs: delay unlink in test-regress-GH-4027.js #14010

wants to merge 2 commits into from

Commits on Jun 30, 2017

  1. test,fs: delay unlink in test-regress-nodejsGH-4027.js 

    The sequential/test-regress-GH-4027 test is flaky with an increased
system load, failing when the watched file is unlinked before the
first state of the watched file is retrieved.

After increasing the delay before unlinking and calling setTimeout
after watchFile, the flakiness stopped reproducing.

Fixes: nodejs#13800
    @jaimecbernardo
    jaimecbernardo committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    e0dfdd2 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2017

  1. fixup: use common.platformTimeout 

    Refs: nodejs#14010 (review)
    @jaimecbernardo
    jaimecbernardo committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    0de3034 View commit details
    Browse the repository at this point in the history