Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix error in eslintrc comment #14108

Closed
wants to merge 1 commit into from
Closed

tools: fix error in eslintrc comment #14108

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 6, 2017

46d7cb8 introduced an error in a
comment in .eslintrc.yaml. The second option needs to be an integer
specifying the number of spaces per level of indentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@Trott
tools: fix error in eslintrc comment
aaf5ca9 
46d7cb8 introduced an error in a
comment in `.eslintrc.yaml`. The second option needs to be an integer
specifying the number of spaces per level of indentation.
@Trott Trott added the tools Issues and PRs related to the tools directory. label Jul 6, 2017
@Trott
Copy link
Member Author

Trott commented Jul 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9014/

refack
refack approved these changes Jul 6, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sure I excluded it. Probably leaked in during a last minute rebase.

@Trott
Copy link
Member Author

Trott commented Jul 7, 2017

Given rapid approvals and trivial nature of change, I'm going to land this now.

@Trott
Copy link
Member Author

Trott commented Jul 7, 2017

Landed in 3d8a9e2

@Trott Trott closed this Jul 7, 2017
Trott added a commit that referenced this pull request Jul 7, 2017
@Trott
tools: fix error in eslintrc comment
3d8a9e2 
46d7cb8 introduced an error in a
comment in `.eslintrc.yaml`. The second option needs to be an integer
specifying the number of spaces per level of indentation.

PR-URL: #14108
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@Trott @addaleax
tools: fix error in eslintrc comment
655371a 
46d7cb8 introduced an error in a
comment in `.eslintrc.yaml`. The second option needs to be an integer
specifying the number of spaces per level of indentation.

PR-URL: #14108
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
@addaleax addaleax mentioned this pull request Jul 11, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@Trott @addaleax
tools: fix error in eslintrc comment
e17fb82 
46d7cb8 introduced an error in a
comment in `.eslintrc.yaml`. The second option needs to be an integer
specifying the number of spaces per level of indentation.

PR-URL: #14108
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@Trott @Fishrock123
tools: fix error in eslintrc comment
3a80508 
46d7cb8 introduced an error in a
comment in `.eslintrc.yaml`. The second option needs to be an integer
specifying the number of spaces per level of indentation.

PR-URL: #14108
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

@targos
Copy link
Member

targos commented Aug 16, 2017

This PR depends on a change that is being backported in #14841.
The backport PR does not contain the error fixed here so we can skip this one.

@Trott Trott deleted the fix-minor-error branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aqrln aqrln aqrln approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @MylesBorins @targos @refack @cjihrig @aqrln @vsemozhetbyt