[v8.x backport] doc: removed redundant mentions to error codes #14175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#13627 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs-github-bot
added
doc
2 tasks
refack
suggested changes
Jul 11, 2017
doc/api/errors.md
Outdated
|
|
||
| <a id="ERR_FALSY_VALUE_REJECTION"></a> | ||
| ### ERR_FALSY_VALUE_REJECTION | ||
|
|
||
| Used by the `util.callbackify()` API when a callbackified `Promise` is rejected | ||
| with a falsy value (e.g. `null`). | ||
| The `ERR_FALSY_VALUE_REJECTION` error code is used by the `util.callbackify()` |
There was a problem hiding this comment.
Isn't this one wrong way around?
There was a problem hiding this comment.
Whoops, was too hasty. Thanks for the catch.
gibfahn
approved these changes
Jul 11, 2017
refack
approved these changes
Jul 12, 2017
TimothyGu
reviewed
Jul 12, 2017
| value]` tuple – that is, if an element is not iterable, or does not consist of | ||
| exactly two elements. | ||
| Used when an element in the `iterable` provided to the [WHATWG][WHATWG URL | ||
| API] [`URLSearchParams`constructor][`new URLSearchParams(iterable)`] does not |
There was a problem hiding this comment.
There should be a space between "URLSearchParams" and "constructor".
There was a problem hiding this comment.
Should, but by the magic of GFM it works:
There was a problem hiding this comment.
@refack what you are seeing is just GitHub's CSS. This won't be the case on Node.js' website. Even in GH, copying the text via the clipboard will not contain a space, nor will the browser insert a line break even if one is needed there.
There was a problem hiding this comment.
This issue is in master. I guess it should be addressed with a PR there that then gets backported to 8.x.
addaleax
pushed a commit
that referenced
this pull request
Jul 12, 2017
PR-URL: #13627 Backport-PR-URL: #14175 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #13627 Backport-PR-URL: #14175 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
PR-URL: #13627 Backport-PR-URL: #14175 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13627
PR-URL: #13627
Reviewed-By: Daniel Bevenius [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Timothy Gu [email protected]
Reviewed-By: Colin Ihrig [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc