Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change isAix to isAIX #14263

Closed
wants to merge 1 commit into from
Closed

test: change isAix to isAIX #14263

wants to merge 1 commit into from

Conversation

LipperZack
Copy link
Contributor

@LipperZack LipperZack commented Jul 16, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
  • tests and/or benchmarks are included
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Jul 16, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. This makes the naming more consistent with existing properties like isFreeBSD where the capitalization of the property name is consistent with the conventional styling of the operating system.

@TimothyGu
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9141/

@TimothyGu TimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
@Trott
Copy link
Member

Trott commented Jul 16, 2017

CI looks good. (Only failure is build related and not anything to do with this change.)

Most of the code-and-learn things can probably land without waiting the full 24 hours. This is probably no exception, but since it does touch a larger-than-usual number of files for Code + Learn, I'd like a few more approvals from others first...

@Trott
Copy link
Member

Trott commented Jul 16, 2017

Landed in fb37922.

Thanks for the contribution! 🎉

@Trott Trott closed this Jul 16, 2017
Trott pushed a commit that referenced this pull request Jul 16, 2017
@LipperZack @Trott
test: change isAix to isAIX
fb37922 
This makes the naming more consistent with existing properties like
isFreeBSD where the capitalization of the property name is consistent
with the conventional styling of the operating system.

PR-URL: #14263
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@gibfahn gibfahn added the aix Issues and PRs related to the AIX platform. label Jul 16, 2017
addaleax pushed a commit that referenced this pull request Jul 24, 2017
@LipperZack @addaleax
test: change isAix to isAIX
d7a1637 
This makes the naming more consistent with existing properties like
isFreeBSD where the capitalization of the property name is consistent
with the conventional styling of the operating system.

PR-URL: #14263
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@refack refack mentioned this pull request Jul 24, 2017
Closed
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

@jasnell
Copy link
Member

jasnell commented Aug 17, 2018

Marking list as a don't land on v8.x largely because it does not appear to be necessary.

@Trott
Copy link
Member

Trott commented Aug 17, 2018 •
edited
Loading

Marking list as a don't land on v8.x largely because it does not appear to be necessary.

Removing the dont-land-on-v8.x label because it appeared in 8.3.0.

d7a1637897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@bengl bengl bengl approved these changes

Assignees
No one assigned
Labels
aix Issues and PRs related to the AIX platform. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LipperZack @TimothyGu @Trott @MylesBorins @jasnell @bengl @gibfahn @nodejs-github-bot