Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSConf CN Code&Learn] Replace the string concatenation with template literals #14284

Closed
wants to merge 2 commits into from
Closed

[JSConf CN Code&Learn] Replace the string concatenation with template literals #14284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6412da
JSConf2017 Code+Learn
HSUCHING Jul 16, 2017
b2ee637
JSConf2017 Code+Learn
HSUCHING Jul 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/parallel/test-http-upgrade-client2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ const CRLF = '\r\n';

const server = http.createServer();
server.on('upgrade', function(req, socket, head) {
socket.write('HTTP/1.1 101 Ok' + CRLF +
'Connection: Upgrade' + CRLF +
'Upgrade: Test' + CRLF + CRLF + 'head');
socket.write(`HTTP/1.1 101 Ok${CRLF}` +
`Connection: Upgrade${CRLF}` +
`Upgrade: Test${CRLF}${CRLF}` +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CRLF is a bit pointless here. I'd just replace it with \r\n literals and avoid the template string entirely.

'head');
socket.on('end', function() {
socket.end();
});
Expand Down