Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace with template literals #14293

Closed
wants to merge 3 commits into from
Closed

test: replace with template literals #14293

wants to merge 3 commits into from

Conversation

Suixinlei
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
Trott
Trott requested changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional changes added do not look good to me. Can you remove them and put them in a separate PR please?

gibfahn
gibfahn approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the last commit this LGTM.

benjamingr
benjamingr reviewed Jul 16, 2017
View reviewed changes
test/inspector/inspector-helper.js
@@ -393,7 +393,7 @@ Harness.prototype.addStderrFilter = function(regexp, callback) {

Harness.prototype.assertStillAlive = function() {
assert.strictEqual(this.running_, true,
'Child died: ' + JSON.stringify(this.result_));
`Child died: ${JSON.stringify(this.result_)}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually the last one to worry about that sort of stuff - but is it possible this terminology is offensive? If we swapped out other trigger references I think it would be nice to have a code base without dead children.

It's entirely appropriate in terms of my culture and language background - but I want to check how others feel about it. If someone feels strongly - will open an issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a not native speaker, I think this can be disturbing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lexically this has reasonable affinity with #13684, so makes sense to change the wordings, though through another PR - as the objective of this one is to introduce template strings and is met.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make it Child exited ${JSON.stringify(this.result_)}

@Trott
Copy link
Member

Trott commented Jul 24, 2017

I force-pushed out the one commit I objected to. Other three commits are all fine.

CI: https://ci.nodejs.org/job/node-test-pull-request/9316/

@benjamingr benjamingr mentioned this pull request Jul 24, 2017
Closed
3 tasks
@Trott
Copy link
Member

Trott commented Jul 25, 2017

Sole CI failure is an unrelated known-flaky test.

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 25, 2017
@Suixinlei @Trott
test: replace concatenation with template literals
c24a73d 
PR-URL: nodejs#14293
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott
Copy link
Member

Trott commented Jul 25, 2017

Landed in c24a73d

Thanks for the contribution! 🎉

@Trott Trott closed this Jul 25, 2017
addaleax pushed a commit that referenced this pull request Jul 27, 2017
@Suixinlei @addaleax
test: replace concatenation with template literals
3c50c59 
PR-URL: #14293
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@jasnell jasnell jasnell left review comments

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Suixinlei @Trott @jasnell @benjamingr @targos @gireeshpunathil @vsemozhetbyt @gibfahn @MylesBorins @nodejs-github-bot