Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-async-wrap-getasyncid flakyness #14329

Closed
wants to merge 1 commit into from
Closed

test: fix test-async-wrap-getasyncid flakyness #14329

wants to merge 1 commit into from

Commits on Jul 17, 2017

  1. test: fix test-async-wrap-getasyncid flakyness 

    The test used to assume that if the client successfully writes data to
the server and closes the connection, then the server must have received
that data and ran its connection callback wrapped by common.mustCall.

However, it is not necessarily the case, and as a result the test was
flaky.

With this change, the server is closed only once the server's connection
callback has been called, which guarantees that the server can accept
connections until it actually accepted the single connection that this
test requires to accept, making the test not flaky.

Fixes: nodejs#13020
    Julien Gilli committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    7764854 View commit details
    Browse the repository at this point in the history