(v6.x backport) process: add --redirect-warnings command line argument #14418
Conversation
nodejs-github-bot
added
c++
jasnell
added
the
semver-minor
The --redirect-warnings command line argument allows process warnings to be written to a specified file rather than printed to stderr. Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable. If the specified file cannot be opened or written to for any reason, the argument is ignored and the warning is printed to stderr. If the file already exists, it will be appended to. PR-URL: nodejs#10116 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michal Zasso <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
sam-github
force-pushed
the
v6.x-backport-redirect-warnings
branch
from
da1f2b3
to
a879dc8
Compare
The --redirect-warnings command line argument allows process warnings to be written to a specified file rather than printed to stderr. Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable. If the specified file cannot be opened or written to for any reason, the argument is ignored and the warning is printed to stderr. If the file already exists, it will be appended to. Backport-PR-URL: #14418 PR-URL: #10116 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michal Zasso <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
|
@nodejs/lts I think I landed this on v6.x-staging in error, looking at https://github.com/nodejs/LTS/wiki#q4-2017-boron-6x-release-schedule, we are only planning a minor every 4 months? At least, its 4 months from the June 6 release of 6.11.0 and the Nov 7th planned release of 6.12.0. I misremembered the cadence as being a release a month, with every other month being a minor. I guess I should back it out and restore the branch? |
|
@MylesBorins did this go into the rc? If so it'd probably be better for Myles to back it out (so he knows what's going on). I'm a little surprised by the delay until the next minor, 4 months seems a little excessive. Maybe open an issue in lts and we can discuss at the next meeting. |
|
Please back this out, it has not been included in the latest RC We can do a minor next month if we want. I documented the options in the release schedule found in the wiki |
|
Popped this off of v6.x-staging, re-PRed. |
The --redirect-warnings command line argument allows process warnings to be written to a specified file rather than printed to stderr. Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable. If the specified file cannot be opened or written to for any reason, the argument is ignored and the warning is printed to stderr. If the file already exists, it will be appended to. Backport-PR-URL: nodejs#14418 PR-URL: nodejs#10116 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michal Zasso <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.
Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.
If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.
If the file already exists, it will be appended to.
PR-URL: #10116
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Michal Zasso [email protected]
Reviewed-By: Fedor Indutny [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)