Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] assert: make assert.fail doc compliant #14428

Closed
wants to merge 2 commits into from
Closed

[v8.x backport] assert: make assert.fail doc compliant #14428

wants to merge 2 commits into from

Commits on Jul 24, 2017

  1. doc,assert: document stackStartFunction in fail 

    PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @BridgeAR @refack
    BridgeAR authored and refack committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    94fecdf View commit details
    Browse the repository at this point in the history

  2. assert: refactor the code 

    1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

PR-URL: nodejs#13862
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @BridgeAR @refack
    BridgeAR authored and refack committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    b95ba5b View commit details
    Browse the repository at this point in the history